Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo links #3093

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Fix repo links #3093

merged 1 commit into from
Dec 5, 2017

Conversation

ethantkoenig
Copy link
Member

Fixes incorrect links in the repository listing of a user profile, as described #3035.

This PR does not address the other points raised in #3035, e.g.

  • whether it makes sense to have "Show more repos" link to a user's profile page
  • whether it makes sense to initially show only a user's repos on their profile page, but include collaborative repos when searching on the profile page

Therefore, we probably should not close #3035 if/when this PR merged.

@codecov-io
Copy link

Codecov Report

Merging #3093 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3093   +/-   ##
=======================================
  Coverage   33.26%   33.26%           
=======================================
  Files         273      273           
  Lines       39954    39954           
=======================================
  Hits        13290    13290           
+ Misses      24768    24763    -5     
- Partials     1896     1901    +5
Impacted Files Coverage Δ
models/repo_indexer.go 47.52% <0%> (-1.49%) ⬇️
models/repo.go 38.15% <0%> (-0.19%) ⬇️
models/issue.go 45.05% <0%> (+0.19%) ⬆️
models/error.go 32.72% <0%> (+0.61%) ⬆️
models/issue_indexer.go 67.53% <0%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2738eff...c8477b4. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 5, 2017
@lafriks
Copy link
Member

lafriks commented Dec 5, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 5, 2017
@lunny
Copy link
Member

lunny commented Dec 5, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 5, 2017
@lunny lunny added this to the 1.4.0 milestone Dec 5, 2017
@lunny lunny merged commit 03eb47b into go-gitea:master Dec 5, 2017
@ethantkoenig ethantkoenig deleted the fix/user_repos branch December 5, 2017 19:46
lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request Dec 12, 2017
@lafriks lafriks added the backport/done All backports for this PR have been created label Dec 12, 2017
@lunny
Copy link
Member

lunny commented Dec 12, 2017

Also fix #3148

lafriks added a commit that referenced this pull request Dec 12, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Awkward behavior of "Repositories" on my profile page
5 participants