Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix body margin shifting with modals, fix error on project column edit #30831

Merged
merged 6 commits into from
May 3, 2024
Merged

Fix body margin shifting with modals, fix error on project column edit #30831

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f7b26b
Fix body margin shifting with modals
silverwind May 2, 2024
3a2aec7
Update web_src/css/base.css
silverwind May 2, 2024
c732ba1
move var decl
silverwind May 2, 2024
012f9dc
Merge branch 'main' into arg1
silverwind May 2, 2024
ede1781
Update web_src/js/modules/fomantic/dimmer.js
silverwind May 2, 2024
8d61375
Merge branch 'main' into arg1
GiteaBot May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web_src/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ body {
flex-direction: column;
overflow-x: visible;
overflow-wrap: break-word;
scrollbar-gutter: stable;
silverwind marked this conversation as resolved.
Show resolved Hide resolved
}

textarea {
Expand Down
5 changes: 4 additions & 1 deletion web_src/js/modules/fomantic/dimmer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {queryElemChildren} from '../../utils/dom.js';

export function initFomanticDimmer() {
// stand-in for removed dimmer module
$.fn.dimmer = function (arg0, $el) {
$.fn.dimmer = function (arg0, arg1) {
if (arg0 === 'add content') {
const existingDimmer = document.querySelector('body > .ui.dimmer');
if (existingDimmer) {
Expand All @@ -14,6 +14,7 @@ export function initFomanticDimmer() {
this._dimmer.classList.add('ui', 'dimmer');
document.body.append(this._dimmer);
}
const $el = arg1;
this._dimmer.append($el[0]);
} else if (arg0 === 'get dimmer') {
return $(this._dimmer);
Expand All @@ -23,6 +24,8 @@ export function initFomanticDimmer() {
} else if (arg0 === 'hide') {
this._dimmer.classList.remove('active');
document.body.classList.remove('tw-overflow-hidden');
const cb = arg1;
cb();
}
return this;
};
Expand Down
Loading