Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix body margin shifting with modals, fix error on project column edit #30831

Merged
merged 6 commits into from
May 3, 2024
Merged

Fix body margin shifting with modals, fix error on project column edit #30831

merged 6 commits into from
May 3, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 2, 2024 •
edited
Loading

Fixes: #30816, regression from #30723.
Fixes: #30815, regression from #30723.

Fomantic expects a callback to be called during hide which we did not do, so it could never remove the margin it added to body.

I do observe the body content shifting to right by 1px when modal opens, but this is a bug that existed on v1.21 as well, so not a regression.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 2, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 2, 2024
silverwind
silverwind commented May 2, 2024
View reviewed changes
web_src/css/base.css Outdated Show resolved Hide resolved
@silverwind silverwind mentioned this pull request May 2, 2024
Closed
silverwind and others added 2 commits May 2, 2024 19:07
@silverwind
Copy link
Member Author

silverwind commented May 2, 2024 •
edited
Loading

I do observe the body content shifting to right by 1px when modal opens, but this is a bug that existed on v1.21 as well, so not a regression.

Apparently this is only a problem in Firefox. No content shift in Chrome. In Firefox there is a 1px difference in this calculation:

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2024
@silverwind
Copy link
Member Author

I do observe the body content shifting to right by 1px when modal opens, but this is a bug that existed on v1.21 as well, so not a regression.

Apparently this is only a problem in Firefox. No content shift in Chrome. In Firefox there is a 1px difference in this calculation:
image

Definitely a browser bug, not something we can fix. It does not happen at 100% page zoom level.

@silverwind
Copy link
Member Author

silverwind commented May 2, 2024 •
edited
Loading

I do observe the body content shifting to right by 1px when modal opens, but this is a bug that existed on v1.21 as well, so not a regression.

Apparently this is only a problem in Firefox. No content shift in Chrome. In Firefox there is a 1px difference in this calculation:
image

I give up on this. Even Chrome shows a 1px diff in some zoom levels. Likely this is expected behaviour in browsers, idk.

image

When we replace the modal module, we ought to find a better way than trying to measure the scrollbar.

@silverwind silverwind changed the title Fix body margin shifting with modals Fix body margin shifting with modals, fix error on project column edit May 2, 2024
@silverwind silverwind mentioned this pull request May 2, 2024
Closed
@silverwind
Copy link
Member Author

No backport as #30723 is not in v1.22.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 3, 2024
@lunny lunny enabled auto-merge (squash) May 3, 2024 01:43
@lunny lunny merged commit b30b7df into go-gitea:main May 3, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 3, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 3, 2024
@wxiaoguang wxiaoguang deleted the arg1 branch May 3, 2024 02:05
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 3, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6e5359c 
* giteaofficial/main: (30 commits)
  Improve grep search (go-gitea#30843)
  Don't only list code-enabled repositories when using repository API (go-gitea#30817)
  Fix no edit history after editing issue's title and content (go-gitea#30814)
  Ignore useless error message "broken pipe" (go-gitea#30801)
  Fix JS error on pull request page (go-gitea#30838)
  Fix body margin shifting with modals, fix error on project column edit (go-gitea#30831)
  Improve repo button row layout (go-gitea#30668)
  refactor: merge ListActionTasks func to action.go file (go-gitea#30811)
  Prevent automatic OAuth grants for public clients (go-gitea#30790)
  Catch and handle unallowed file type errors in issue attachment API (go-gitea#30791)
  Fix incorrect message id for releaes email (go-gitea#30825)
  Add hover outline to heatmap squares (go-gitea#30828)
  Remove external API calls in `TestPassword` (go-gitea#30716)
  Upgrade chi-binding (go-gitea#30826)
  Improve context popup rendering (go-gitea#30824)
  Fix activity heat map padding & locale (go-gitea#30823)
  Fix issue card layout (go-gitea#30800)
  Fix branch selector UI (go-gitea#30803)
  Fix rounded border for segment followed by pagination (go-gitea#30809)
  Skip gzip for some well-known compressed file types (go-gitea#30796)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Show modal will cause body width becomeing smaller
4 participants
@silverwind @lunny @wxiaoguang @GiteaBot