Fix JS error when edit project column twice and fix empty column title #30815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
yp05327
added
topic/ui
yp05327
changed the title
lunny
approved these changes
May 2, 2024
GiteaBot
added
lgtm/need 1
|
Should this be backport? |
|
Not sure which PR caused this issue. |
|
Odd. I can't imagine #30723 having caused this which is the only possible related commit not on the branch. |
wxiaoguang
reviewed
May 2, 2024
There was a problem hiding this comment.
This fix doesn't seem complete.
The root problem is that all modals are destroyed.
https://github.com/go-gitea/gitea/pull/30723/files#r1587350910
GiteaBot
added
lgtm/blocked
|
Better fix in #30831 |
lunny
pushed a commit
that referenced
this pull request
May 3, 2024
#30831) Fixes: #30816, regression from #30723. Fixes: #30815, regression from #30723. Fomantic [expects a callback](https://github.com/fomantic/Fomantic-UI/blob/59d9b409879ad9413ea0a3efa4ab2e51017ad9b9/src/definitions/modules/modal.js#L530-L534) to be called during `hide` which we did not do, so it could never remove the margin it added to `body`. I do observe the body content shifting to right by 1px when modal opens, but this is a bug that existed on v1.21 as well, so not a regression. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce:
And fix column title will be changed if the input is empty