Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove box-shadow from UI, fix dashboard issue #3065

Merged
merged 2 commits into from
Dec 2, 2017

Conversation

silverwind
Copy link
Member

Two tweaks here:

  1. Remove box-shadow from menus and segments. I think it generally looks better this way because most of the UI elements are already flat, and the box-shadowed elements look out-of-place.

Before

screen shot 2017-12-02 at 18 41 40

After

screen shot 2017-12-02 at 18 41 58

  1. Fix a issue where the repo list in the dashboard sidebar was 2px wider than the pill menu above it. The cause of the issue looks to be some hacks in Semantic UI and that added artificial width to that repo box.

Before

screen shot 2017-12-02 at 18 41 04

After

screen shot 2017-12-02 at 18 39 42

@silverwind
Copy link
Member Author

Fun fact: gogs has done a similar change on hiding the box-shadows. I just went ahead and adopted the change as it seemed cleaner.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 2, 2017
@codecov-io
Copy link

codecov-io commented Dec 2, 2017

Codecov Report

Merging #3065 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3065      +/-   ##
==========================================
- Coverage   33.45%   33.42%   -0.04%     
==========================================
  Files         270      270              
  Lines       39553    39553              
==========================================
- Hits        13232    13219      -13     
- Misses      24429    24445      +16     
+ Partials     1892     1889       -3
Impacted Files Coverage Δ
models/repo_indexer.go 45.54% <0%> (-6.44%) ⬇️
modules/indexer/repo.go 60.86% <0%> (-2.61%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef53649...10297f2. Read the comment docs.

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Dec 2, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 2, 2017
@lafriks
Copy link
Member

lafriks commented Dec 2, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2017
@lafriks
Copy link
Member

lafriks commented Dec 2, 2017

@silverwind please resolve conflicts

@silverwind
Copy link
Member Author

Rebased.

@lafriks
Copy link
Member

lafriks commented Dec 2, 2017

Can you please force push?

@silverwind
Copy link
Member Author

done

@lafriks lafriks merged commit 4947cfb into go-gitea:master Dec 2, 2017
@silverwind silverwind deleted the css-tweaks branch December 3, 2017 03:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants