Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and fix archive link bug (#30535) #30570

Merged
merged 5 commits into from
Apr 21, 2024
Merged

Refactor and fix archive link bug (#30535) #30570

merged 5 commits into from
Apr 21, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Apr 18, 2024 •
edited by wxiaoguang
Loading

Backport #30535 by wxiaoguang

Regression of #29920
Fixes: #30569

Also this is a rewriting to eliminate the remaining jQuery usages from code.

@wxiaoguang @GiteaBot
Refactor and fix archive link bug (go-gitea#30535)
3b018ee 
Regression of go-gitea#29920
Fixes: go-gitea#30569

Also this is a rewriting to eliminate the remaining jQuery usages from code.

Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 18, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 18, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 18, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 18, 2024
@silverwind silverwind enabled auto-merge (squash) April 18, 2024 16:47
@silverwind
Copy link
Member

@wxiaoguang seems we are missing applyElemsCallback on this branch.

@silverwind silverwind self-requested a review April 18, 2024 16:49
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2024
@wxiaoguang
Copy link
Contributor

I won't spend time on backporting, the 1.22 branch is broken in my mind.

@wxiaoguang wxiaoguang closed this Apr 19, 2024
auto-merge was automatically disabled April 19, 2024 01:33

Pull request was closed

This was referenced Apr 19, 2024
Merged
Closed
@GiteaBot GiteaBot removed this from the 1.22.0 milestone Apr 19, 2024
@silverwind silverwind reopened this Apr 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 19, 2024
silverwind
silverwind reviewed Apr 19, 2024
View reviewed changes
web_src/js/utils/dom.js Outdated Show resolved Hide resolved
@silverwind
Copy link
Member

silverwind commented Apr 19, 2024 •
edited
Loading

I replaced applyElemsCallback with querySelectorAll, will test later. That would have been my preferred way on main branch anyways.

@silverwind silverwind self-requested a review April 19, 2024 07:38
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2024
@silverwind
Copy link
Member

Fixed and tested

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 21, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2024
@silverwind silverwind merged commit fc376c8 into go-gitea:release/v1.22 Apr 21, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 21, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@silverwind silverwind silverwind approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees

@wxiaoguang wxiaoguang

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @silverwind @wxiaoguang @delvh