-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve flex ellipsis #30479
Improve flex ellipsis #30479
Conversation
wxiaoguang
commented
Apr 14, 2024
b28bc6d
to
a3cbeb9
Compare
I wonder if |
See the code: |
There won't be more places. If we use |
No, it should be on the flex children, e.g.
|
Oh yes, my example is not accurate for this case. Will add more. |
Maybe add some examples where you you three elements, and some with two. I would also name the page as "Ellipsis examples", not specific to labels. |
Feel free to edit this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess it won't break anything at least.
No backport, see #30344 (comment). Shouldn't have merged this. I really wonder why we didn't put the fixes into that PR instead. |
Partial revert: #30481 |
* origin/main: Improve flex ellipsis (go-gitea#30479) Remove fomantic button module (go-gitea#30475) Improve "must-change-password" logic and document (go-gitea#30472) Fix commitstatus summary (go-gitea#30431) Remove fomantic menu module (go-gitea#30325) Use `flex-container` for dashboard layout (go-gitea#30214) Rewrite and restyle reaction selector and enable no-sizzle eslint rule (go-gitea#30453) Pulse page improvements (go-gitea#30149) Fix JS error when opening to expanded code comment (go-gitea#30463) fix: Fix to delete cookie when AppSubURL is non-empty (go-gitea#30375) Add `interface{}` to `any` replacement to `make fmt`, exclude `*.pb.go` (go-gitea#30461) Fix network error when open/close organization/individual projects and redirect to project page (go-gitea#30387) Avoid losing token when updating mirror settings (go-gitea#30429)
Partial revert of #30479 It's causing problems at least here: #30344 (comment) --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* giteaofficial/main: [skip ci] Updated licenses and gitignores Revert 100% label max-width (go-gitea#30481) Improve flex ellipsis (go-gitea#30479) Remove fomantic button module (go-gitea#30475) Improve "must-change-password" logic and document (go-gitea#30472) Fix commitstatus summary (go-gitea#30431) Remove fomantic menu module (go-gitea#30325) Use `flex-container` for dashboard layout (go-gitea#30214) Rewrite and restyle reaction selector and enable no-sizzle eslint rule (go-gitea#30453) Pulse page improvements (go-gitea#30149)
Partial revert of go-gitea/gitea#30479 It's causing problems at least here: go-gitea/gitea#30344 (comment) --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> (cherry picked from commit ef3941f2ebe9d8353f9546e7df00b24092c71cb7)