Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing 0 prefix of GPG key id #30245

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Fix missing 0 prefix of GPG key id #30245

merged 1 commit into from
Apr 2, 2024

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Apr 2, 2024 •
edited
Loading

Fixes #30235

If the key id "front" byte has a single digit, %X is missing the 0 prefix.
38D1A3EADDBEA9C instead of
038D1A3EADDBEA9C
When using the IssuerFingerprint slice %X is enough but I changed it to %016X too to be consistent.

@KN4CK3R KN4CK3R added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 labels Apr 2, 2024
@KN4CK3R KN4CK3R added this to the 1.23.0 milestone Apr 2, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 2, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 2, 2024
@KN4CK3R KN4CK3R mentioned this pull request Apr 2, 2024
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 2, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 2, 2024
@KN4CK3R KN4CK3R merged commit eb505b1 into go-gitea:main Apr 2, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 2, 2024
@KN4CK3R @GiteaBot
Fix missing 0 prefix of GPG key id (go-gitea#30245)
70ceb1b 
Fixes go-gitea#30235

If the key id "front" byte has a single digit, `%X` is missing the 0
prefix.
` 38D1A3EADDBEA9C` instead of
`038D1A3EADDBEA9C`
When using the `IssuerFingerprint` slice `%X` is enough but I changed it
to `%016X` too to be consistent.
@GiteaBot GiteaBot mentioned this pull request Apr 2, 2024
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 2, 2024
@KN4CK3R @GiteaBot
Fix missing 0 prefix of GPG key id (go-gitea#30245)
c6def18 
Fixes go-gitea#30235

If the key id "front" byte has a single digit, `%X` is missing the 0
prefix.
` 38D1A3EADDBEA9C` instead of
`038D1A3EADDBEA9C`
When using the `IssuerFingerprint` slice `%X` is enough but I changed it
to `%016X` too to be consistent.
@GiteaBot GiteaBot mentioned this pull request Apr 2, 2024
Merged
@KN4CK3R KN4CK3R deleted the fix-signature-key-id-format branch April 2, 2024 15:51
KN4CK3R added a commit that referenced this pull request Apr 2, 2024
@GiteaBot @KN4CK3R
Fix missing 0 prefix of GPG key id (#30245) (#30247)
935bfe6 
Backport #30245 by @KN4CK3R

Fixes #30235

If the key id "front" byte has a single digit, `%X` is missing the 0
prefix.
` 38D1A3EADDBEA9C` instead of
`038D1A3EADDBEA9C`
When using the `IssuerFingerprint` slice `%X` is enough but I changed it
to `%016X` too to be consistent.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
KN4CK3R added a commit that referenced this pull request Apr 2, 2024
@GiteaBot @KN4CK3R
Fix missing 0 prefix of GPG key id (#30245) (#30248)
deaabf6 
Backport #30245 by @KN4CK3R

Fixes #30235

If the key id "front" byte has a single digit, `%X` is missing the 0
prefix.
` 38D1A3EADDBEA9C` instead of
`038D1A3EADDBEA9C`
When using the `IssuerFingerprint` slice `%X` is enough but I changed it
to `%016X` too to be consistent.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@GiteaBot
Copy link
Contributor

GiteaBot commented Apr 2, 2024

I was unable to create a backport for 1.21. @KN4CK3R, please send one manually. 🍵

go run ./contrib/backport 30245
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 2, 2024
@GiteaBot
Copy link
Contributor

GiteaBot commented Apr 2, 2024

I was unable to create a backport for 1.22. @KN4CK3R, please send one manually. 🍵

go run ./contrib/backport 30245
...  // fix git conflicts if any
go run ./contrib/backport --continue

HenriquerPimentel pushed a commit to HenriquerPimentel/gitea that referenced this pull request Apr 2, 2024
@KN4CK3R @HenriquerPimentel
Fix missing 0 prefix of GPG key id (go-gitea#30245)
63b69e8 
Fixes go-gitea#30235

If the key id "front" byte has a single digit, `%X` is missing the 0
prefix.
` 38D1A3EADDBEA9C` instead of
`038D1A3EADDBEA9C`
When using the `IssuerFingerprint` slice `%X` is enough but I changed it
to `%016X` too to be consistent.
@KN4CK3R KN4CK3R added backport/done All backports for this PR have been created and removed backport/manual No power to the bots! Create your backport yourself! labels Apr 3, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 3, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ceeb71e 
* giteaofficial/main:
  Refactor "dump" sub-command (go-gitea#30240)
  Add -u git to docs when using docker exec with root installation (go-gitea#29314)
  Show 12 lines in markup code preview (go-gitea#30255)
  Fixes go-gitea#27605: inline math blocks can't be preceeded/followed by alphanumerical characters (go-gitea#30175)
  Render embedded code preview by permlink in markdown (go-gitea#30234)
  Fix missing 0 prefix of GPG key id (go-gitea#30245)
  Fix spacing in issue navbar (go-gitea#30238)
  Add unique index for project_issue to prevent duplicate data (go-gitea#30190)
  [skip ci] Updated translations via Crowdin
  Refactor commit signature parser (go-gitea#30228)
  Refactor dropzone (go-gitea#30232)
  Remove scheduled action tasks if the repo is archived (go-gitea#30224)
  Refactor file view & render (go-gitea#30227)
  Refactor DeleteInactiveUsers, fix bug and add tests (go-gitea#30206)
  [skip ci] Updated licenses and gitignores
  Add `/options/license` and `/options/gitignore` to `.ignore` (go-gitea#30219)
@silverwind silverwind mentioned this pull request Apr 3, 2024
Merged
AvengerMoJo pushed a commit to AvengerMoJo/gitea that referenced this pull request Apr 8, 2024
@KN4CK3R @AvengerMoJo
Fix missing 0 prefix of GPG key id (go-gitea#30245)
0d1784f 
Fixes go-gitea#30235

If the key id "front" byte has a single digit, `%X` is missing the 0
prefix.
` 38D1A3EADDBEA9C` instead of
`038D1A3EADDBEA9C`
When using the `IssuerFingerprint` slice `%X` is enough but I changed it
to `%016X` too to be consistent.
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

GPG signed commit rendered differently if signed with subkey instead of master key.
5 participants
@KN4CK3R @GiteaBot @lunny @delvh @wxiaoguang