Fix markdown color code detection #30208
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wxiaoguang
added
backport/v1.22
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
When reviewing PRs, some color names might be mentioned, the `transformCodeSpan` (which calls `css.ColorHandler`) considered it as a valid color, but actually it shouldn't be rendered as a color codespan.
Backport #30208 by wxiaoguang When reviewing PRs, some color names might be mentioned, the `transformCodeSpan` (which calls `css.ColorHandler`) considered it as a valid color, but actually it shouldn't be rendered as a color codespan. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
| @@ -49,9 +49,28 @@ func (r *HTMLRenderer) renderCodeSpan(w util.BufWriter, source []byte, n ast.Nod | |||
| return ast.WalkContinue, nil | |||
| } | |||
|
|
|||
| // cssColorHandler checks if a string is a render-able CSS color value. | |||
| // The code is from "github.com/microcosm-cc/bluemonday/css.ColorHandler", except that it doesn't handle color words like "red". | |||
There was a problem hiding this comment.
This "link" is 404. I wonder if it can handle hex RRGGBBAA syntax.
There was a problem hiding this comment.
It is not a link, it just refers to the package and its method.
And, modern IDE could resolve the method name:
There was a problem hiding this comment.
I wonder if it can handle hex RRGGBBAA syntax.
There was a problem hiding this comment.
Ok. Seems far-fetched that a IDE should highlight inside "links". Better to put web links next time.
There was a problem hiding this comment.
And no, I don't mean rgba() syntax, bug #rrggbbaa and also #rgba.
There was a problem hiding this comment.
It's a upstream bug that it does not support 4-digit #rgba:
https://developer.mozilla.org/en-US/docs/Web/CSS/hex-color#syntax
There was a problem hiding this comment.
Ok. Seems far-fetched that a IDE should highlight inside "links". Better to put web links next time.
But Golang's package import is not a link, it is just a package path : "github.com/microcosm-cc/bluemonday/css"
There was a problem hiding this comment.
And no, I don't mean
rgba()syntax, bug#rrggbbaaand also#rgba.
It's a upstream bug that it does not support#rgba:
Sorry, I don't understand what do you mean. I think #rgba is well-supported.
OK, I see your point, you only mean #rgba the short format.
There was a problem hiding this comment.
No, it only support 3,6,8 length, not 4 length.
There was a problem hiding this comment.
Opened microcosm-cc/bluemonday#207
* giteaofficial/main: Remove fomantic input module (go-gitea#30194) Remove most jQuery function calls from the repository topic box (go-gitea#30191) Prevent flash of dropdown menu on labels list (go-gitea#30215) Remove jQuery class from the `repo-issue.js` file (go-gitea#30192) Ignore fomantic folder in linters (go-gitea#30200) Remove `modifies/frontend` from labeler (go-gitea#30198) Make a distinction between `active` and `selected` in the issue author dropdown (go-gitea#30207) Move and simplify tab-size helpers (go-gitea#30196) Fix markdown color code detection (go-gitea#30208)
wxiaoguang
added
the
skip-changelog
When reviewing PRs, some color names might be mentioned, the
transformCodeSpan(which callscss.ColorHandler) considered it as a valid color, but actually it shouldn't be rendered as a color codespan.