Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery .attr from the common issue page functions #30083

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Remove jQuery .attr from the common issue page functions #30083

merged 6 commits into from
Mar 26, 2024

Commits on Mar 25, 2024

  1. Remove jQuery .attr from the common issue page functions 

    - Switched from jQuery `attr` to plain javascript `getAttribute` and `setAttribute`
- Tested most of the functions and they work as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
    @yardenshoham
    yardenshoham committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    8228dcd View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Update web_src/js/features/repo-issue.js 

    Co-authored-by: silverwind <me@silverwind.io>
    @yardenshoham @silverwind
    yardenshoham and silverwind authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    fdb8bc9 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: silverwind <me@silverwind.io>
    @yardenshoham @delvh @silverwind
    3 people authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    20fe9b0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into repo-issue-jquery-attr

    @yardenshoham
    yardenshoham authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6e33f3f View commit details
    Browse the repository at this point in the history

  4. Move functions to outer scope

    @yardenshoham
    yardenshoham committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    1579b43 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into repo-issue-jquery-attr

    @yardenshoham
    yardenshoham authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ae8c68c View commit details
    Browse the repository at this point in the history