Remove fomantic header module #30033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
silverwind
added
the
type/refactoring
silverwind
added
the
skip-changelog
pull-request-size
bot
added
size/XXL
github-actions
bot
added
modifies/templates
pull-request-size
bot
added
size/XL
|
I removed the |
delvh
reviewed
Mar 23, 2024
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
delvh
approved these changes
Mar 23, 2024
GiteaBot
added
lgtm/need 1
silverwind
commented
Mar 23, 2024
pull-request-size
bot
added
size/XXL
denyskon
approved these changes
Mar 24, 2024
GiteaBot
added
lgtm/done
denyskon
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 24, 2024
* origin/main: Dont show expansion for empty actions steps (go-gitea#29977) Remove fomantic header module (go-gitea#30033)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 24, 2024
* origin/main: Dont show expansion for empty actions steps (go-gitea#29977) Remove fomantic header module (go-gitea#30033)
lunny
pushed a commit
that referenced
this pull request
Mar 25, 2024
Fix regression from #30033 These buttons had lost their border because `.ui.header` sets `none` but `.ui.menu` has it, after the migration, the order of styles changed and header won. I see no reason why those have the `header` class in first place, besides for semantic meaning. Before: <img width="491" alt="Screenshot 2024-03-25 at 00 39 27" src="https://github.com/go-gitea/gitea/assets/115237/fa1b7505-75cf-4854-a97f-db3c46f31e93"> After: <img width="496" alt="Screenshot 2024-03-25 at 00 39 14" src="https://github.com/go-gitea/gitea/assets/115237/8f6bdc07-9596-436b-8c82-9af283300004">
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Mar 30, 2024
Fix regression from go-gitea/gitea#30033 These buttons had lost their border because `.ui.header` sets `none` but `.ui.menu` has it, after the migration, the order of styles changed and header won. I see no reason why those have the `header` class in first place, besides for semantic meaning. Before: <img width="491" alt="Screenshot 2024-03-25 at 00 39 27" src="https://github.com/go-gitea/gitea/assets/115237/fa1b7505-75cf-4854-a97f-db3c46f31e93"> After: <img width="496" alt="Screenshot 2024-03-25 at 00 39 14" src="https://github.com/go-gitea/gitea/assets/115237/8f6bdc07-9596-436b-8c82-9af283300004"> (cherry picked from commit 8717c1c2bef1afcc6b0bb2d84627b158b95836b0)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely still a few useless classes left, but I think I at least don't have missed any.