Fix 500 when pushing release to an empty repo #29554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/api
lng2020
added
type/bug
backport/v1.21
techknowlogick
approved these changes
Mar 3, 2024
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Mar 3, 2024
GiteaBot
added
lgtm/done
delvh
approved these changes
Mar 3, 2024
silverwind
added
the
reviewed/wait-merge
github-actions
bot
added
the
modifies/api
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 3, 2024
As title. The former code directly used `ctx.Repo.GitRepo`, causing 500. https://github.com/go-gitea/gitea/blob/22b4f0c09f1de5e581929bd10f39833d30d2c482/routers/api/v1/repo/release.go#L241
GiteaBot
added
backport/done
silverwind
pushed a commit
that referenced
this pull request
Mar 3, 2024
Backport #29554 by @lng2020 As title. The former code directly used `ctx.Repo.GitRepo`, causing 500. https://github.com/go-gitea/gitea/blob/22b4f0c09f1de5e581929bd10f39833d30d2c482/routers/api/v1/repo/release.go#L241 Co-authored-by: Nanguan Lin <nanguanlin6@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 4, 2024
* upstream/main: Replace some `gt-` classes with `tw-` (go-gitea#29570) Enable/disable owner and repo projects independently (go-gitea#28805) Add an trailing slash to dashboard links (go-gitea#29555) Extend issue template yaml engine (go-gitea#29274) [skip ci] Updated licenses and gitignores Fix workflow trigger event IssueChangeXXX bug (go-gitea#29559) Fix 500 when pushing release to an empty repo (go-gitea#29554) Update js and py dependencies, bump python (go-gitea#29561) Filter Repositories by type (go-gitea#29231)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
The former code directly used
ctx.Repo.GitRepo, causing 500.gitea/routers/api/v1/repo/release.go
Line 241 in 22b4f0c