Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix language names #2955

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Fix language names #2955

merged 1 commit into from
Nov 23, 2017

Conversation

0rzech
Copy link
Contributor

@0rzech 0rzech commented Nov 21, 2017

Make language names grammatical in defaults.go and app.ini.

@codecov-io
Copy link

codecov-io commented Nov 21, 2017 •
edited
Loading

Codecov Report

Merging #2955 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2955      +/-   ##
==========================================
+ Coverage    26.8%   26.82%   +0.01%     
==========================================
  Files          90       90              
  Lines       17807    17807              
==========================================
+ Hits         4774     4777       +3     
+ Misses      12353    12351       -2     
+ Partials      680      679       -1
Impacted Files Coverage Δ
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d781a...4ab99c1. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 22, 2017
@appleboy appleboy added the type/enhancement An improvement of existing functionality label Nov 22, 2017
@appleboy appleboy added this to the 1.4.0 milestone Nov 22, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 22, 2017
@lafriks
Copy link
Member

lafriks commented Nov 22, 2017

Please rebase

@sapk
Copy link
Member

sapk commented Nov 22, 2017

Why dropping the capitalization on some ?

@lafriks
Copy link
Member

lafriks commented Nov 22, 2017

@sapk in some languages language names are not written capitalized as in English. At least I can confirm this is correct for Latvian, don't know about others

@sapk
Copy link
Member

sapk commented Nov 22, 2017

ok, I personally prefer with caps but after verification it seems to be also good for français and I am not the best at grammar. So LGTM.

@0rzech
Copy link
Contributor Author

0rzech commented Nov 23, 2017 •
edited
Loading

@lafriks, @lunny: rebased.

@lunny lunny merged commit 183da4c into go-gitea:master Nov 23, 2017
@0rzech 0rzech deleted the lang-names-fix branch November 23, 2017 20:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
8 participants
@0rzech @codecov-io @ethantkoenig @appleboy @lafriks @sapk @lunny @tboerger