Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memcache support when value is returned as string always #2924

Merged
merged 3 commits into from
Nov 16, 2017
Merged

Fix memcache support when value is returned as string always #2924

merged 3 commits into from
Nov 16, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Nov 15, 2017

Fixes #2920

@lafriks lafriks added this to the 1.3.0 milestone Nov 15, 2017
@codecov-io
Copy link

codecov-io commented Nov 15, 2017 •
edited
Loading

Codecov Report

Merging #2924 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2924   +/-   ##
=======================================
  Coverage   27.26%   27.26%           
=======================================
  Files          89       89           
  Lines       17640    17640           
=======================================
  Hits         4809     4809           
  Misses      12144    12144           
  Partials      687      687

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222e7c3...98c41fa. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 15, 2017
@lunny
Copy link
Member

lunny commented Nov 16, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 16, 2017
@ethantkoenig
Copy link
Member

LGTM, but how were strings added to the cache in the first place?

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2017
@lafriks
Copy link
Member Author

lafriks commented Nov 16, 2017

@ethantkoenig when saved in memcached it saves value in it as string

@lafriks
Copy link
Member Author

lafriks commented Nov 16, 2017

Make LG-TM work

@lunny lunny merged commit 7c3e605 into go-gitea:master Nov 16, 2017
@lafriks lafriks deleted the fix/memcache_support branch November 20, 2017 23:40
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Nov 20, 2017
@lafriks
Fix memcache support when value is returned as string always (go-gite…
6629d54 
…a#2924)
@lafriks lafriks mentioned this pull request Nov 20, 2017
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 20, 2017
lunny pushed a commit that referenced this pull request Nov 21, 2017
@lafriks @lunny
Fix memcache support when value is returned as string always (#2924) (#…
c31e877 
…2950)
@lafriks lafriks modified the milestones: 1.3.0, 1.4.0 Nov 27, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

HTTP 500 when entering project page
6 participants
@lafriks @codecov-io @lunny @ethantkoenig @appleboy @tboerger