Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable owner and repo projects independently #28805

Merged
merged 28 commits into from
Mar 4, 2024

Conversation

denyskon
Copy link
Member

@denyskon denyskon commented Jan 15, 2024

Part of #23318

Add menu in repo settings to allow for repo admin to decide not just if projects are enabled or disabled per repo, but also which kind of projects (repo-level/owner-level) are enabled. If repo projects disabled, don't show the projects tab.

grafik

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 15, 2024
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them labels Jan 15, 2024
@denyskon denyskon requested a review from delvh January 15, 2024 16:26
@denyskon denyskon added type/enhancement An improvement of existing functionality topic/projects modifies/templates This PR modifies the template files labels Jan 15, 2024
@github-actions github-actions bot removed the modifies/templates This PR modifies the template files label Jan 15, 2024
@denyskon denyskon added this to the 1.22.0 milestone Jan 15, 2024
routers/web/repo/compare.go Outdated Show resolved Hide resolved
routers/web/repo/compare.go Outdated Show resolved Hide resolved
routers/web/repo/issue.go Outdated Show resolved Hide resolved
@denyskon
Copy link
Member Author

denyskon commented Feb 6, 2024

Bump... would be thankful for more reviews :)

@6543
Copy link
Member

6543 commented Feb 26, 2024

old message deleted,
wrong browser tab ...

@silverwind
Copy link
Member

silverwind commented Feb 26, 2024

image

This screenshot has some problems:

  1. Why are the checkboxes not vertically aligned?
  2. Why inconsistent casing of the "repository" and "projects" words?
  3. Why do options one and two negate each other? Shouldn't it be just one checkbox?
  4. "owner projects" seems unclear to me. Maybe add a tooltip detailing what those are?

@6543
Copy link
Member

6543 commented Feb 26, 2024

image

is possible and makes UX wise no sense

@denyskon denyskon requested a review from 6543 February 26, 2024 20:15
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2024
@delvh delvh changed the title Add possibility to enable/disable owner and repo projects independently Enable/disable owner and repo projects independently Mar 2, 2024
options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
models/repo/repo_unit.go Show resolved Hide resolved
routers/web/repo/issue.go Outdated Show resolved Hide resolved
templates/repo/settings/options.tmpl Outdated Show resolved Hide resolved
@denyskon denyskon requested a review from delvh March 3, 2024 14:00
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2024
@6543 6543 enabled auto-merge (squash) March 4, 2024 02:31
@6543 6543 merged commit fe6792d into go-gitea:main Mar 4, 2024
26 checks passed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 4, 2024
* upstream/main:
  Replace some `gt-` classes with `tw-` (go-gitea#29570)
  Enable/disable owner and repo projects independently (go-gitea#28805)
  Add an trailing slash to dashboard links (go-gitea#29555)
  Extend issue template yaml engine (go-gitea#29274)
  [skip ci] Updated licenses and gitignores
  Fix workflow trigger event IssueChangeXXX bug (go-gitea#29559)
  Fix 500 when pushing release to an empty repo (go-gitea#29554)
  Update js and py dependencies, bump python (go-gitea#29561)
  Filter Repositories by type (go-gitea#29231)
@denyskon denyskon deleted the projects-switch branch March 4, 2024 18:23
@denyskon denyskon mentioned this pull request Mar 4, 2024
silverwind pushed a commit that referenced this pull request Mar 4, 2024
Fix for regressions introduced by #28805 

Enabled projects on repos created before the PR weren't detected. Also,
the way projects mode was detected in settings didn't match the way it
was detected on permission check, which leads to confusion.

Co-authored-by: Giteabot <teabot@gitea.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/projects type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants