Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetCommitStatuses (#28787) #28802

Closed
wants to merge 1 commit into from
Closed

Fix GetCommitStatuses (#28787) #28802

wants to merge 1 commit into from

Conversation

GiteaBot
Copy link
Contributor

Backport #28787 by @KN4CK3R

Fixes #28764.

@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them type/bug labels Jan 15, 2024
@GiteaBot GiteaBot added this to the 1.21.4 milestone Jan 15, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2024
@GiteaBot GiteaBot requested a review from delvh January 15, 2024 14:07
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 15, 2024
@GiteaBot GiteaBot requested a review from lunny January 15, 2024 14:07
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2024
@lunny
Copy link
Member

lunny commented Jan 15, 2024

This PR needs manual changes.

@KN4CK3R
Copy link
Member

KN4CK3R commented Jan 15, 2024

1.21 FindAndCount does not behave like the 1.22 one. There is no order support. Is a helper model method needed?

@lunny
Copy link
Member

lunny commented Jan 15, 2024

1.21 FindAndCount does not behave like the 1.22 one. There is no order support. Is a helper model method needed?

Maybe rollback to your previous version. A helper model method is also OK.

@KN4CK3R KN4CK3R mentioned this pull request Jan 15, 2024
Merged
@KN4CK3R
Copy link
Member

KN4CK3R commented Jan 15, 2024

Replaced with #28804.

@KN4CK3R KN4CK3R closed this Jan 15, 2024
@GiteaBot GiteaBot removed this from the 1.21.4 milestone Jan 15, 2024
KN4CK3R added a commit that referenced this pull request Jan 15, 2024
@KN4CK3R
Fix GetCommitStatuses (#28787) (#28804)
ae99233 
Backport #28787

Replaces #28802
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees

@KN4CK3R KN4CK3R

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @KN4CK3R @delvh