Avoid unnecessary 500 panic when a commit doesn't exist (#28719) #28721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In go-gitea#26851, it assumed that `Commit` always exists when `PageIsDiff==true`. But for a 404 page, the `Commit` doesn't exist, so the following code would cause panic because nil value can't be passed as string parameter to `IsMultilineCommitMessage(string)` (or the StringUtils.Cut in later PRs)
GiteaBot
added
the
skip-changelog
GiteaBot
added
the
lgtm/need 2
wxiaoguang
approved these changes
Jan 7, 2024
GiteaBot
added
lgtm/need 1
denyskon
approved these changes
Jan 7, 2024
GiteaBot
added
the
lgtm/done
wxiaoguang
added
type/bug
and removed
lgtm/need 1
delvh
approved these changes
Jan 7, 2024
delvh
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #28719 by @wxiaoguang
In #26851, it assumed that
Commitalways exists whenPageIsDiff==true.But for a 404 page, the
Commitdoesn't exist, so the following code would cause panic because nil value can't be passed as string parameter toIsMultilineCommitMessage(string)(or the StringUtils.Cut in later PRs)