Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve document for ARTIFACT_RETENTION_DAYS #28646

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Improve document for ARTIFACT_RETENTION_DAYS #28646

merged 2 commits into from
Dec 29, 2023

Conversation

wxiaoguang
Copy link
Contributor

Follow #28626

@wxiaoguang wxiaoguang added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.21 This PR should be backported to Gitea 1.21 labels Dec 29, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Dec 29, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 29, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 29, 2023
@wxiaoguang wxiaoguang mentioned this pull request Dec 29, 2023
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 29, 2023
lng2020
lng2020 reviewed Dec 29, 2023
View reviewed changes
Copy link
Member

@lng2020 lng2020 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set to 0 to disable artifact retention

I think this one is forgotten.

@wxiaoguang
Copy link
Contributor Author

Set to 0 to disable artifact retention

I think this one is forgotten.

Nope, it is not forgotten, but it is just incorrect.

image

lng2020
lng2020 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@lng2020 lng2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better than that PR

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 29, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 29, 2023
@lunny lunny enabled auto-merge (squash) December 29, 2023 06:44
@lunny lunny merged commit 19b1b69 into go-gitea:main Dec 29, 2023
24 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 29, 2023
@wxiaoguang @GiteaBot
Improve document for ARTIFACT_RETENTION_DAYS (go-gitea#28646)
0395807 
Follow go-gitea#28626
@GiteaBot GiteaBot mentioned this pull request Dec 29, 2023
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 29, 2023
@wxiaoguang wxiaoguang deleted the fix-doc-retention branch December 29, 2023 06:46
wxiaoguang added a commit that referenced this pull request Dec 29, 2023
@GiteaBot @wxiaoguang
Improve document for ARTIFACT_RETENTION_DAYS (#28646) (#28648)
f7cca2a 
Backport #28646 by wxiaoguang

Follow #28626

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 30, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
d705bd2 
* giteaoffical/main:
  Update JS dependencies (go-gitea#28537)
  Improve document for ARTIFACT_RETENTION_DAYS (go-gitea#28646)
  fix empty ref for cron workflow runs (go-gitea#28640)
  Improve 1.22 document for Database Preparation (go-gitea#28643)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Improve document for ARTIFACT_RETENTION_DAYS (go-gitea#28646)
e71ec5a 
Follow go-gitea#28626
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@wxiaoguang @silverwind
Improve document for ARTIFACT_RETENTION_DAYS (go-gitea#28646)
05e5afc 
Follow go-gitea#28626
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lng2020 lng2020 lng2020 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @lng2020 @GiteaBot