Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to url auth to header auth in tests #28484

Merged
merged 7 commits into from
Dec 21, 2023

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Dec 15, 2023

Related #28390

@KN4CK3R KN4CK3R added type/testing type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Dec 15, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 15, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 15, 2023
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 20, 2023
@jackHay22
Copy link
Contributor

👍

@kdumontnu
Copy link
Contributor

MVP

@KN4CK3R KN4CK3R marked this pull request as ready for review December 21, 2023 22:00
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Dec 21, 2023

Converted all parameter calls into header authorization. There are lots of changed lines but I promise 100% test coverage.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 21, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 21, 2023
@lunny lunny enabled auto-merge (squash) December 21, 2023 22:57
@lunny lunny merged commit 838db2f into go-gitea:main Dec 21, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 22, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 22, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 22, 2023
* giteaofficial/main:
  Add more ways to try (go-gitea#28581)
  Convert to url auth to header auth in tests (go-gitea#28484)
  Fix 500 error of searching commits (go-gitea#28576)
  improve possible performance bottleneck (go-gitea#28547)
  Use information from previous blame parts (go-gitea#28572)
  Make offline mode as default to no connect external avatar service by default (go-gitea#28548)
  Fix merging artifact chunks error when minio storage basepath is set (go-gitea#28555)
  feat: bump `dessant/lock-threads` and `actions/setup-go` to use nodejs20 runtime (go-gitea#28565)
  Update actions document about comparsion as Github Actions (go-gitea#28560)
  Fix inperformant query on retrifing review from database. (go-gitea#28552)
  Fix the issue ref rendering for wiki (go-gitea#28556)
  Add missing head of lfs client batch (go-gitea#28550)
  [skip ci] Updated translations via Crowdin
  Remove deadcode under models/issues (go-gitea#28536)
  Always enable caches (go-gitea#28527)
  Improve ObjectFormat interface (go-gitea#28496)
techknowlogick pushed a commit to techknowlogick/gitea that referenced this pull request Dec 23, 2023
lunny pushed a commit that referenced this pull request Dec 23, 2023
Follow up to #28484, this PR
enables the setting for integration tests and migrates a few additional
test queries.
@KN4CK3R KN4CK3R deleted the fix-tests-token-auth branch December 23, 2023 18:15
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
Follow up to go-gitea#28484, this PR
enables the setting for integration tests and migrates a few additional
test queries.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
Follow up to go-gitea#28484, this PR
enables the setting for integration tests and migrates a few additional
test queries.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants