Require clear descriptions both for feature and breaking PRs prior to the merge #28112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
added
type/docs
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lafriks
approved these changes
Nov 18, 2023
GiteaBot
added
lgtm/need 1
denyskon
approved these changes
Nov 18, 2023
GiteaBot
added
lgtm/done
|
Should I add it to this PR? |
How about that? |
|
Sounds good. Maybe add:
|
yardenshoham
approved these changes
Nov 18, 2023
|
Labels are now required to be correct too. |
denyskon
approved these changes
Nov 18, 2023
6543
approved these changes
Nov 19, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 20, 2023
* upstream/main: [skip ci] Updated translations via Crowdin Update JS and PY dependencies (go-gitea#28120) Decrease issue font size in project template (go-gitea#28054) Require clear descriptions both for feature and breaking PRs prior to the merge (go-gitea#28112) add skip ci functionality (go-gitea#28075) Fix project counter in organization/individual profile (go-gitea#28068) Fix Show/hide filetree button on small displays (go-gitea#27881) Change default size of attachments and repo files (go-gitea#28100) Fix Matrix and MSTeams nil dereference (go-gitea#28089)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
… the merge (go-gitea#28112) When writing the release blog, it is really annoying and time-consuming to re-discover and write down how a feature behaves and capture a screenshot of it, for every single feature merged since the last release. This should not be the responsibility of maintainers, but rather of the person implementing a feature in the first place. They know best how to use the feature and how to gather screenshots for it. Similarly for breaking changes and their effects. As such, let's require everything to be up-to-date and easily understandable before merging features or breaking changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing the release blog, it is really annoying and time-consuming to re-discover and write down how a feature behaves and capture a screenshot of it, for every single feature merged since the last release.
This should not be the responsibility of maintainers, but rather of the person implementing a feature in the first place.
They know best how to use the feature and how to gather screenshots for it.
Similarly for breaking changes and their effects.
As such, let's require everything to be up-to-date and easily understandable before merging features or breaking changes.