Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Matrix and MSTeams nil dereference #28089

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Nov 16, 2023

Fixes #28088
Fixes #28094

Added missing tests.

@KN4CK3R KN4CK3R added type/bug topic/webhooks backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 labels Nov 16, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 16, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 16, 2023
@KN4CK3R KN4CK3R mentioned this pull request Nov 16, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 16, 2023
To avoid unnecessary database access, the `cacheTime` should always be
set if the revision has been checked.

Fix go-gitea#28057
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 17, 2023
services/webhook/matrix.go Outdated Show resolved Hide resolved
@KN4CK3R KN4CK3R merged commit 58f5fa6 into go-gitea:main Nov 17, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Nov 17, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 17, 2023
Fixes go-gitea#28088 
Fixes go-gitea#28094

Added missing tests.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 17, 2023
@KN4CK3R KN4CK3R deleted the fix-webhook-nil branch November 17, 2023 11:17
lunny added a commit that referenced this pull request Nov 17, 2023
Backport #28089 by @KN4CK3R

Fixes #28088 
Fixes #28094

Added missing tests.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 20, 2023
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Update JS and PY dependencies (go-gitea#28120)
  Decrease issue font size in project template (go-gitea#28054)
  Require clear descriptions both for feature and breaking PRs prior to the merge (go-gitea#28112)
  add skip ci functionality (go-gitea#28075)
  Fix project counter in organization/individual profile (go-gitea#28068)
  Fix Show/hide filetree button on small displays (go-gitea#27881)
  Change default size of attachments and repo files (go-gitea#28100)
  Fix Matrix and MSTeams nil dereference (go-gitea#28089)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
Fixes go-gitea#28088 
Fixes go-gitea#28094

Added missing tests.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/webhooks type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"PANIC: runtime error" when pushing container to Gitea container registry nil dereference in webhooks
6 participants