Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add skip ci functionality #28075

Merged
merged 16 commits into from
Nov 18, 2023
Merged

add skip ci functionality #28075

merged 16 commits into from
Nov 18, 2023

Conversation

denyskon
Copy link
Member

@denyskon denyskon commented Nov 15, 2023 •
edited
Loading

Adds the possibility to skip workflow execution if the commit message contains a string like [skip ci] or similar.

The default strings are the same as on GitHub, users can also set custom ones in app.ini

Reference: https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs

Close #28020

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 15, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2023
@denyskon denyskon added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Nov 15, 2023
@denyskon denyskon added this to the 1.22.0 milestone Nov 15, 2023
@denyskon denyskon added the topic/gitea-actions related to the actions of Gitea label Nov 15, 2023
@denyskon denyskon requested a review from delvh November 15, 2023 17:10
@delvh
Copy link
Member

delvh commented Nov 15, 2023

I'll be probably be able to review on saturday.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 16, 2023
lng2020
lng2020 suggested changes Nov 16, 2023
View reviewed changes
services/actions/notifier_helper.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2023
delvh
delvh approved these changes Nov 16, 2023
View reviewed changes
services/actions/notifier_helper.go Outdated Show resolved Hide resolved
lng2020
lng2020 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@lng2020 lng2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as delvh but not a blocker.
BTW, probably should add more other tests in action_trigger_test.go. But not this PR's duty.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Nov 17, 2023
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 17, 2023
@wxiaoguang wxiaoguang removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 17, 2023
@wxiaoguang
Copy link
Contributor

app.example.ini should also be updated.

@denyskon
Copy link
Member Author

@wxiaoguang Done

@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 17, 2023
@GiteaBot
Copy link
Contributor

@denyskon please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 17, 2023
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 17, 2023
@wxiaoguang wxiaoguang removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 18, 2023
@wxiaoguang

This comment was marked as outdated.

Sign in to view
@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 18, 2023
@lafriks lafriks merged commit 816e46e into go-gitea:main Nov 18, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 18, 2023
@jacksgt jacksgt mentioned this pull request Nov 18, 2023
Closed
@denyskon denyskon deleted the skip-ci branch November 18, 2023 13:37
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 20, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
a44608a 
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Update JS and PY dependencies (go-gitea#28120)
  Decrease issue font size in project template (go-gitea#28054)
  Require clear descriptions both for feature and breaking PRs prior to the merge (go-gitea#28112)
  add skip ci functionality (go-gitea#28075)
  Fix project counter in organization/individual profile (go-gitea#28068)
  Fix Show/hide filetree button on small displays (go-gitea#27881)
  Change default size of attachments and repo files (go-gitea#28100)
  Fix Matrix and MSTeams nil dereference (go-gitea#28089)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@denyskon @fuxiaohei
add skip ci functionality (go-gitea#28075)
5d35cc3 
Adds the possibility to skip workflow execution if the commit message
contains a string like [skip ci] or similar.

The default strings are the same as on GitHub, users can also set custom
ones in app.ini

Reference:
https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs

Close go-gitea#28020
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChristopherHX ChristopherHX ChristopherHX left review comments

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lng2020 lng2020 lng2020 approved these changes

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/gitea-actions related to the actions of Gitea type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Support skipping Gitea Action workflows [ci skip] [no ci] ...
8 participants
@denyskon @delvh @wxiaoguang @GiteaBot @lunny @ChristopherHX @lng2020 @lafriks