Skip to content

Remove set tabindex on view issue (#27892) #27896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2023
Merged

Remove set tabindex on view issue (#27892) #27896

merged 1 commit into from
Nov 3, 2023

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Nov 3, 2023

Backport #27892 by @earl-warren

@earl-warren @Gusted
@wxiaoguang @GiteaBot
Remove "tabindex" from some form buttons (go-gitea#27892)
d998a1e 
Remove the "tabindex" from some form buttons on the "diff box" / "issue view content" page, let the browser use the default tab order.

---------

Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added modifies/templates This PR modifies the template files topic/accessibility This issue/pull request wants to improve the accessibility labels Nov 3, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 3, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Nov 3, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2023
@lunny lunny merged commit cf7374c into go-gitea:release/v1.21 Nov 3, 2023
@denyskon denyskon added the type/enhancement An improvement of existing functionality label Nov 13, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jolheiser jolheiser jolheiser approved these changes

@denyskon denyskon denyskon approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files topic/accessibility This issue/pull request wants to improve the accessibility type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.21.0

Development

Successfully merging this pull request may close these issues.

5 participants

@GiteaBot @jolheiser @denyskon @lunny @earl-warren