Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: enable route support for websocket connections #27806

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+13 −0
Draft

WIP: enable route support for websocket connections #27806

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
753e594
enable websocket support
ExplodingDragon Oct 27, 2023
62a9e83
enable websocket support
ExplodingDragon Oct 27, 2023
b89517c
remove deprecated package
ExplodingDragon Oct 28, 2023
30541b6
Merge branch 'main' into feature-websocket-support
ExplodingDragon Oct 28, 2023
09c892f
Merge branch 'main' into feature-websocket-support
ExplodingDragon Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions modules/context/response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
package context

import (
"bufio"
"errors"
"net"
"net/http"

web_types "code.gitea.io/gitea/modules/web/types"
Expand All @@ -30,6 +33,14 @@ type Response struct {
status int
befores []func(ResponseWriter)
beforeExecuted bool
hijacker http.Hijacker
}

func (r *Response) Hijack() (net.Conn, *bufio.ReadWriter, error) {
if r.hijacker == nil {
return nil, nil, errors.New("http.Hijacker not implemented by underlying http.ResponseWriter")
}
return r.hijacker.Hijack()
}

// Write writes bytes to HTTP endpoint
Expand Down Expand Up @@ -95,9 +106,11 @@ func WrapResponseWriter(resp http.ResponseWriter) *Response {
if v, ok := resp.(*Response); ok {
return v
}
hijacker, _ := resp.(http.Hijacker)
return &Response{
ResponseWriter: resp,
status: 0,
befores: make([]func(ResponseWriter), 0),
hijacker: hijacker,
}
}