Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: enable route support for websocket connections #27806

Closed
wants to merge 5 commits into from
Closed

WIP: enable route support for websocket connections #27806

wants to merge 5 commits into from

Conversation

ExplodingDragon
Copy link
Contributor

link: #27766

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 27, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2023
@ExplodingDragon ExplodingDragon mentioned this pull request Oct 27, 2023
Open
@silverwind
Copy link
Member

Did we already implement websocket connections in backend? I thought that was still planned.

@anbraten anbraten mentioned this pull request Jan 27, 2024
Draft
3 tasks
@wxiaoguang
Copy link
Contributor

More details here: #28958 (comment)

I think we need to refactor and replace the existing EventSource first but not just introduce a new module, otherwise the code would go unmaintainable.

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Jan 1, 2025
@wxiaoguang
Copy link
Contributor

Inactive for long time, do we need to keep this PR open?

This PR's change seems simple enough, there is always a chance to introduce websocket support if there is a clear plan.

If we'd like to introduce some new features, either there is a plan and implement them step by step, or put the websocket and the feature code in one PR.

@ExplodingDragon
Copy link
Contributor Author

Thanks. I will close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobDev JakobDev JakobDev left review comments

Assignees
No one assigned
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ExplodingDragon @silverwind @wxiaoguang @JakobDev @GiteaBot