-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix display member unit in the menu bar if there are no hidden members in public org #27795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Oct 26, 2023
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Oct 26, 2023
github-actions
bot
added
the
modifies/templates
This PR modifies the template files
label
Oct 26, 2023
puni9869
approved these changes
Oct 26, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Oct 26, 2023
puni9869
reviewed
Oct 26, 2023
@@ -27,14 +27,14 @@ | |||
{{end}} | |||
|
|||
{{if .ContextUser.IsOrganization}} | |||
{{if .IsOrganizationMember}} | |||
<a class="item" href="{{$.OrgLink}}/members"> | |||
{{if .NumMembers}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NumMembers
is num or bool
lunny
approved these changes
Oct 30, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Oct 30, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Oct 30, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Oct 30, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 31, 2023
* giteaofficial/main: Fix package webhook (go-gitea#27839) Add user secrets API integration tests (go-gitea#27832) Fix wrong relative path on obtain token from command line (go-gitea#27850) doc: actions/act-runner: document obtaining a runner registration token from gitea CLI (go-gitea#27845) Fix/upload artifact error windows (go-gitea#27802) Always use whole user name as link (go-gitea#27815) Fix display member unit in the menu bar if there are no hidden members in public org (go-gitea#27795) Add Index to pull_auto_merge.doer_id (go-gitea#27811) Bump workflows in github actions (go-gitea#27836) Allow pull requests Manually Merged option to be used by non-admins (go-gitea#27780)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
…s in public org (go-gitea#27795) Follow go-gitea#26363. I missed that org templates also using `templates/user/overview/header.tmpl`. You can confirm this problem in https://gitea.com/gitea/-/projects with anonymous access. Before: (no login) ![image](https://github.com/go-gitea/gitea/assets/18380374/e285565c-ca65-4b18-9ff7-434c6367c13a) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/81e7532a-c458-4552-8d75-6896538e42cb)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/templates
This PR modifies the template files
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #26363.
I missed that org templates also using
templates/user/overview/header.tmpl
.You can confirm this problem in https://gitea.com/gitea/-/projects with anonymous access.
Before: (no login)
After: