Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data-race bug when accessing task.LastRun #27584

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Fix data-race bug when accessing task.LastRun #27584

merged 3 commits into from
Oct 11, 2023

Conversation

wxiaoguang
Copy link
Contributor

No description provided.

@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Oct 11, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 11, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2023
@wxiaoguang wxiaoguang mentioned this pull request Oct 11, 2023
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 11, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Oct 11, 2023

Shouldn't the lock include the lines above too?

next = e.NextRun()
prev = e.PreviousRun()

They could change if the task runs at that moment.

@wxiaoguang
Copy link
Contributor Author

Shouldn't the lock include the lines above too?

next = e.NextRun()
prev = e.PreviousRun()

They could change if the task runs at that moment.

That's another problem (not directly related).

This PR only fixes the lock for this:

image

KN4CK3R
KN4CK3R approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@KN4CK3R KN4CK3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 11, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) October 11, 2023 13:32
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. backport/v1.21 This PR should be backported to Gitea 1.21 labels Oct 11, 2023
@silverwind
Copy link
Member

silverwind commented Oct 11, 2023 •
edited
Loading

Backport needed? Edit: lunny just set it :)

@wxiaoguang wxiaoguang merged commit 1d155a4 into go-gitea:main Oct 11, 2023
25 checks passed
@GiteaBot GiteaBot mentioned this pull request Oct 11, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 11, 2023
@wxiaoguang @GiteaBot
Fix data-race bug when accessing task.LastRun (go-gitea#27584)
228b81a
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 11, 2023
silverwind pushed a commit that referenced this pull request Oct 11, 2023
@GiteaBot @wxiaoguang
Fix data-race bug when accessing task.LastRun (#27584) (#27586)
844ab9a 
Backport #27584 by @wxiaoguang

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 12, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b80e30c 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Keep filter when showing unfiltered results on explore page (go-gitea#27192)
  Don't show Link to TOTP if not set up (go-gitea#27585)
  Fix data-race bug when accessing task.LastRun (go-gitea#27584)
  Fix template bug (go-gitea#27581)
  Replace ajax with fetch, improve image diff (go-gitea#27267)
  Replace assert.Fail with assert.FailNow (go-gitea#27578)
  Fix the robots.txt path
  show manual cron run's last time (go-gitea#27544)
  fully replace drone with actions (go-gitea#27556)
  Revert "Simplify `contrib/backport` (go-gitea#27520)" (go-gitea#27566)
  Align ISSUE_TEMPLATE with the new label system (go-gitea#27573)
  Penultimate round of `db.DefaultContext` refactor (go-gitea#27414)
@wxiaoguang wxiaoguang deleted the fix-task-datarace branch October 12, 2023 02:13
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wxiaoguang @KN4CK3R @silverwind @lunny @delvh @GiteaBot