-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the mirror repo URL from edit form since it can't be changed #27487
base: main
Are you sure you want to change the base?
Conversation
I believe that is there so that the user is aware of which URL they are modifying since push mirrors can have multiple URLs. |
At least, it could be a readonly input box. |
it is readonly and disabled |
Here was approach PS: please see the screenshots in the PR desc. |
No. It's read only but not disabled. see (https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/readonly#attribute_interactions) |
Think about it, there is always a better solution, we can discuss on the designs. or can take help/feedbacks from other maintainers |
Before:
After:
Or just change the background color of the input box 🤔 ?