Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the mirror repo URL from edit form since it can't be changed #27487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lng2020
Copy link
Member

@lng2020 lng2020 commented Oct 6, 2023

Before:
image
After:
image

Or just change the background color of the input box 🤔 ?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2023
@github-actions github-actions bot added the topic/ui Change the appearance of the Gitea UI label Oct 6, 2023
@techknowlogick
Copy link
Member

I believe that is there so that the user is aware of which URL they are modifying since push mirrors can have multiple URLs.

@lunny
Copy link
Member

lunny commented Oct 7, 2023

At least, it could be a readonly input box.

@lng2020
Copy link
Member Author

lng2020 commented Oct 7, 2023

I believe that is there so that the user is aware of which URL they are modifying since push mirrors can have multiple URLs.

1DRHG5SLQE)K%$8 _78WH_F
There are different lines in the table so different records are just not easy to mix up. I deleted the input box just because the edit form title is Edit mirror sync internal.

At least, it could be a readonly input box.

%RKQMK8~MF 1 O9CC2F2BNS
The input box is read-only but will be active if the mouse clicks, which is easily confused.

PS:
)P5HWUC$Q9L{LY8M2~AR EC
I think the table also should add one column to indicate the current interval time.

So let's vote 😸

  1. remove the URL input box or disable the input box to non-clickable. 😄 for first, 🚀 for second.
  2. add a column to indicate the current sync interval time. 👍 or 👎

@puni9869
Copy link
Member

puni9869 commented Oct 9, 2023

I believe that is there so that the user is aware of which URL they are modifying since push mirrors can have multiple URLs.

1DRHG5SLQE)K%$8 _78WH_F There are different lines in the table so different records are just not easy to mix up. I deleted the input box just because the edit form title is Edit mirror sync internal.

At least, it could be a readonly input box.

%RKQMK8~MF 1 O9CC2F2BNS The input box is read-only but will be active if the mouse clicks, which is easily confused.

PS: )P5HWUC$Q9L{LY8M2~AR EC I think the table also should add one column to indicate the current interval time.

So let's vote 😸

  1. remove the URL input box or disable the input box to non-clickable. 😄 for first, 🚀 for second.
  2. add a column to indicate the current sync interval time. 👍 or 👎

I like this initiative

I have a question for you
1 How will you show the user that for which url you are modifiying if you are using the modal
2. I agree with the new design flow 👍 🚀 but I want to see the mock first. It will hamper the mobile view, if you add a new column in the current code, you need to modify that segment of view for mobile.

@puni9869
Copy link
Member

puni9869 commented Oct 9, 2023

At least, it could be a readonly input box.

it is readonly and disabled

@puni9869
Copy link
Member

puni9869 commented Oct 9, 2023

Here was approach
#26151

PS: please see the screenshots in the PR desc.

@lng2020
Copy link
Member Author

lng2020 commented Oct 9, 2023

At least, it could be a readonly input box.

it is readonly and disabled

No. It's read only but not disabled. see (https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/readonly#attribute_interactions)

@lng2020
Copy link
Member Author

lng2020 commented Oct 9, 2023

I believe that is there so that the user is aware of which URL they are modifying since push mirrors can have multiple URLs.

1DRHG5SLQE)K%$8 _78WH_F There are different lines in the table so different records are just not easy to mix up. I deleted the input box just because the edit form title is Edit mirror sync internal.

At least, it could be a readonly input box.

%RKQMK8~MF 1 O9CC2F2BNS The input box is read-only but will be active if the mouse clicks, which is easily confused.
PS: )P5HWUC$Q9L{LY8M2~AR EC I think the table also should add one column to indicate the current interval time.
So let's vote 😸

  1. remove the URL input box or disable the input box to non-clickable. 😄 for first, 🚀 for second.
  2. add a column to indicate the current sync interval time. 👍 or 👎

I like this initiative

I have a question for you 1 How will you show the user that for which url you are modifiying if you are using the modal 2. I agree with the new design flow 👍 🚀 but I want to see the mock first. It will hamper the mobile view, if you add a new column in the current code, you need to modify that segment of view for mobile.

That's true. I wonder if the row has the space for another column. And the current column will display unnormal if I change the browser width too.

@puni9869
Copy link
Member

puni9869 commented Oct 9, 2023

That's true. I wonder if the row has the space for another column. And the current column will display unnormal if I change the browser width too.

Think about it, there is always a better solution, we can discuss on the designs. or can take help/feedbacks from other maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants