Fix Fomantic UI dropdown icon bug when there is a search input in menu #27225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
lunny
approved these changes
Sep 24, 2023
GiteaBot
added
lgtm/need 1
denyskon
approved these changes
Sep 24, 2023
GiteaBot
added
lgtm/done
denyskon
added
the
reviewed/wait-merge
delvh
approved these changes
Sep 24, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 24, 2023
go-gitea#27225) Fix go-gitea#27224 And add the case to the devtest page.
GiteaBot
added
backport/done
lunny
pushed a commit
that referenced
this pull request
Sep 24, 2023
#27225) (#27228) Backport #27225 by @wxiaoguang Fix #27224 And add the case to the devtest page. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
|
Could maybe also be fixed with |
No, it can't. The "dropdown icon" has a special event listener. |
|
Huh, seems pointless 😆. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 25, 2023
* giteaofficial/main: Add missing public user visibility in user details page (go-gitea#27246) Use mask-based fade-out effect for `.new-menu` (go-gitea#27181) [skip ci] Updated translations via Crowdin Fix z-index on markdown completion (go-gitea#27237) Update database-preparation and add note re: MariaDB (go-gitea#27232) cleanup locale function usage (go-gitea#27227) Fix EOL handling in web editor (go-gitea#27141) Fix PushEvent NullPointerException jenkinsci/github-plugin (go-gitea#27203) fix issues on action runners page (go-gitea#27226) Fix Fomantic UI dropdown icon bug when there is a search input in menu (go-gitea#27225) Update go-enry to 2.8.5 (go-gitea#27215) Update nodejs installation method in release container (go-gitea#27207) Quote table `release` in sql queries (go-gitea#27205) Fix push mirror, wrong timestamp format (go-gitea#27153) Allow copying issue comment link on archived repos and when not logged in (go-gitea#27193) fix: text decorator on issue sidebar menu label (go-gitea#27206) Update JS and Poetry dependencies and eslint (go-gitea#27200) Remove some dead code (go-gitea#27196) # Conflicts: # templates/repo/issue/view_content/context_menu.tmpl
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 9, 2023
…gitea#27526) Follow go-gitea#27225 The change in go-gitea#27225 is not ideal, this should be the complete fix: support the layout which Fomantic doesn't support.
wxiaoguang
added a commit
that referenced
this pull request
Oct 9, 2023
) (#27534) Backport #27526 by @wxiaoguang Follow #27225 The change in #27225 is not ideal, this should be the complete fix: support the layout which Fomantic doesn't support. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27224
And add the case to the devtest page.