Fix push mirror, wrong timestamp format #27153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
KN4CK3R
approved these changes
Sep 20, 2023
GiteaBot
added
lgtm/need 1
KN4CK3R
added
the
pr/breaking
github-actions
bot
added
the
modifies/api
delvh
approved these changes
Sep 20, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
reviewed
Sep 21, 2023
lunny
removed
the
reviewed/wait-merge
|
As this is a small fix, could this be merged into the 1.21.0 milestone? |
lunny
reviewed
Sep 21, 2023
| CreatedUnix: pm.CreatedUnix.FormatLong(), | ||
| LastUpdateUnix: pm.LastUpdateUnix.FormatLong(), | ||
| CreatedUnix: pm.CreatedUnix.AsTime(), | ||
| LastUpdateUnix: pm.LastUpdateUnix.AsTimePtr(), |
There was a problem hiding this comment.
pm.LastUpdateUnix is a timeutil.TimeStamp not *timeutil.TimeStamp. It can only be pm.LastUpdateUnix.IsZero() if I'm not mistaken.
There was a problem hiding this comment.
Yeah, I was also a bit confused about that. So I guess I change it back to not be a pointer?
There was a problem hiding this comment.
Ah, so maybe we should change
// AsTimePtrInLocation convert timestamp as *time.Time in customize location
func (ts TimeStamp) AsTimePtrInLocation(loc *time.Location) *time.Time {
tm := time.Unix(int64(ts), 0).In(loc)
return &tm
}to
// AsTimePtrInLocation convert timestamp as *time.Time in customize location
func (ts TimeStamp) AsTimePtrInLocation(loc *time.Location) *time.Time {
if ts.IsZero() {
return nil
}
tm := time.Unix(int64(ts), 0).In(loc)
return &tm
}There was a problem hiding this comment.
So I guess this is resolved and the proposed change should be done in a different PR?
lunny
approved these changes
Sep 22, 2023
|
Do we backport breaking changes? I don't see this PR as a bug fix. |
KN4CK3R
approved these changes
Sep 22, 2023
|
Agree, it's probably better not to backport, sorry @kilimnik. |
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 25, 2023
* giteaofficial/main: Add missing public user visibility in user details page (go-gitea#27246) Use mask-based fade-out effect for `.new-menu` (go-gitea#27181) [skip ci] Updated translations via Crowdin Fix z-index on markdown completion (go-gitea#27237) Update database-preparation and add note re: MariaDB (go-gitea#27232) cleanup locale function usage (go-gitea#27227) Fix EOL handling in web editor (go-gitea#27141) Fix PushEvent NullPointerException jenkinsci/github-plugin (go-gitea#27203) fix issues on action runners page (go-gitea#27226) Fix Fomantic UI dropdown icon bug when there is a search input in menu (go-gitea#27225) Update go-enry to 2.8.5 (go-gitea#27215) Update nodejs installation method in release container (go-gitea#27207) Quote table `release` in sql queries (go-gitea#27205) Fix push mirror, wrong timestamp format (go-gitea#27153) Allow copying issue comment link on archived repos and when not logged in (go-gitea#27193) fix: text decorator on issue sidebar menu label (go-gitea#27206) Update JS and Poetry dependencies and eslint (go-gitea#27200) Remove some dead code (go-gitea#27196) # Conflicts: # templates/repo/issue/view_content/context_menu.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed, that the push mirrors endpoint, is the only endpoint which returns the times in long format rather than as time.Time().
I think the behavior should be consistent across the project.
This PR changes the time format used in API responses for all push_mirror endpoints which return a push mirror.