fix pagination for followers and following #27127

earl-warren · 2023-09-19T04:17:06Z

Use the correct total amount for pagination. Thereby correctly show the pagination bare when there's more than one page of followers/followings.

Refs: https://codeberg.org/forgejo/forgejo/pulls/1477

(cherry picked from commit c1a1363)

- Use the correct total amount for pagination. Thereby correctly show the pagination bare when there's more than one page of followers/followings. Refs: https://codeberg.org/forgejo/forgejo/pulls/1477 (cherry picked from commit c1a1363)

- Use the correct total amount for pagination. Thereby correctly show the pagination bare when there's more than one page of followers/followings. Refs: https://codeberg.org/forgejo/forgejo/pulls/1477 (cherry picked from commit c1a1363) Co-authored-by: Gusted <postmaster@gusted.xyz>

@earl-warren

Backport #27127 by @earl-warren - Use the correct total amount for pagination. Thereby correctly show the pagination bare when there's more than one page of followers/followings. Refs: https://codeberg.org/forgejo/forgejo/pulls/1477 (cherry picked from commit c1a1363) Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com> Co-authored-by: Gusted <postmaster@gusted.xyz>

* giteaofficial/main: Improve actions docs related to `pull_request` event (go-gitea#27126) Remove outdated paragraphs when comparing Gitea Actions to GitHub Actions (go-gitea#27119) Fix: treat tab "overview" as "repositories" in user profiles without readme (go-gitea#27124) Fix incorrect test code for error handling (go-gitea#27139) Increase auth provider icon size on login page (go-gitea#27122) fix pagination for followers and following (go-gitea#27127) services/wiki: Close() after error handling (go-gitea#27129) Use fetch helpers instead of fetch (go-gitea#27026) Change green buttons to primary color (go-gitea#27099) Fix wrong xorm get usage on migration (go-gitea#27111) Fix the incorrect route path in the user edit page. (go-gitea#27007) Refactor lfs requests (go-gitea#26783) Display archived labels specially when listing labels (go-gitea#26820) Remove a `gt-float-right` and some unnecessary helpers (go-gitea#27110) [skip ci] Updated licenses and gitignores Fix token endpoints ignore specified account (go-gitea#27080) Make SSPI auth mockable (go-gitea#27036)

* origin/main: Fix dropdown icon position (go-gitea#27175) Fix repo sub menu (go-gitea#27169) Fix review request number and add more tests (go-gitea#27104) Fix the variable regexp pattern on web page (go-gitea#27161) Fix organization field being null in POST /orgs/{orgid}/teams (go-gitea#27150) Add index to `issue_user.issue_id` (go-gitea#27154) [skip ci] Updated translations via Crowdin Start development on Gitea 1.22 (go-gitea#27155) Fix successful return value for `SyncAndGetUserSpecificDiff` (go-gitea#27152) Improve actions docs related to `pull_request` event (go-gitea#27126) Remove outdated paragraphs when comparing Gitea Actions to GitHub Actions (go-gitea#27119) Fix: treat tab "overview" as "repositories" in user profiles without readme (go-gitea#27124) Fix incorrect test code for error handling (go-gitea#27139) Increase auth provider icon size on login page (go-gitea#27122) fix pagination for followers and following (go-gitea#27127) services/wiki: Close() after error handling (go-gitea#27129) Use fetch helpers instead of fetch (go-gitea#27026) Change green buttons to primary color (go-gitea#27099) Fix wrong xorm get usage on migration (go-gitea#27111)

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.20.4` -> `1.20.5` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the logs for more information. --- ### Release Notes <details> <summary>go-gitea/gitea (docker.io/gitea/gitea)</summary> ### [`v1.20.5`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1205---2023-10-03) [Compare Source](go-gitea/gitea@v1.20.4...v1.20.5) - ENHANCEMENTS - Fix z-index on markdown completion ([#27237](go-gitea/gitea#27237)) ([#27242](go-gitea/gitea#27242) & [#27238](go-gitea/gitea#27238)) - Use secure cookie for HTTPS sites ([#26999](go-gitea/gitea#26999)) ([#27013](go-gitea/gitea#27013)) - BUGFIXES - Fix git 2.11 error when checking IsEmpty ([#27393](go-gitea/gitea#27393)) ([#27396](go-gitea/gitea#27396)) - Allow get release download files and lfs files with oauth2 token format ([#26430](go-gitea/gitea#26430)) ([#27378](go-gitea/gitea#27378)) - Fix orphan check for deleted branch ([#27310](go-gitea/gitea#27310)) ([#27320](go-gitea/gitea#27320)) - Quote table `release` in sql queries ([#27205](go-gitea/gitea#27205)) ([#27219](go-gitea/gitea#27219)) - Fix release URL in webhooks ([#27182](go-gitea/gitea#27182)) ([#27184](go-gitea/gitea#27184)) - Fix successful return value for `SyncAndGetUserSpecificDiff` ([#27152](go-gitea/gitea#27152)) ([#27156](go-gitea/gitea#27156)) - fix pagination for followers and following ([#27127](go-gitea/gitea#27127)) ([#27138](go-gitea/gitea#27138)) - Fix issue templates when blank isses are disabled ([#27061](go-gitea/gitea#27061)) ([#27082](go-gitea/gitea#27082)) - Fix context cache bug & enable context cache for dashabord commits' authors([#26991](go-gitea/gitea#26991)) ([#27017](go-gitea/gitea#27017)) - Fix INI parsing for value with trailing slash ([#26995](go-gitea/gitea#26995)) ([#27001](go-gitea/gitea#27001)) - Fix PushEvent NullPointerException jenkinsci/github-plugin ([#27203](go-gitea/gitea#27203)) ([#27249](go-gitea/gitea#27249)) - Fix organization field being null in POST /orgs/{orgid}/teams ([#27150](go-gitea/gitea#27150)) ([#27167](go-gitea/gitea#27167) & [#27162](go-gitea/gitea#27162)) - Fix bug of review request number ([#27406](go-gitea/gitea#27406)) ([#27104](go-gitea/gitea#27104)) - TESTING - services/wiki: Close() after error handling ([#27129](go-gitea/gitea#27129)) ([#27137](go-gitea/gitea#27137)) - DOCS - Improve actions docs related to `pull_request` event ([#27126](go-gitea/gitea#27126)) ([#27145](go-gitea/gitea#27145)) - MISC - Add logs for data broken of comment review ([#27326](go-gitea/gitea#27326)) ([#27344](go-gitea/gitea#27344)) - Load reviewer before sending notification ([#27063](go-gitea/gitea#27063)) ([#27064](go-gitea/gitea#27064)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.home/nrdufour/home-ops/pulls/129 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>

fix pagination for followers and following

85018d4

- Use the correct total amount for pagination. Thereby correctly show the pagination bare when there's more than one page of followers/followings. Refs: https://codeberg.org/forgejo/forgejo/pulls/1477 (cherry picked from commit c1a1363)

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 19, 2023

pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2023

lunny approved these changes Sep 19, 2023

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 19, 2023

lunny added type/bug backport/v1.20 This PR should be backported to Gitea 1.20 labels Sep 19, 2023

lunny added this to the 1.21.0 milestone Sep 19, 2023

delvh approved these changes Sep 19, 2023

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 19, 2023

silverwind approved these changes Sep 19, 2023

View reviewed changes

silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 19, 2023

silverwind enabled auto-merge (squash) September 19, 2023 14:48

Merge branch 'main' into wip-gitea-followers

2b176df

silverwind merged commit fc09c30 into go-gitea:main Sep 19, 2023
25 checks passed

GiteaBot mentioned this pull request Sep 19, 2023

fix pagination for followers and following (#27127) #27138

Merged

GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 19, 2023

go-gitea locked as resolved and limited conversation to collaborators Dec 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix pagination for followers and following #27127

fix pagination for followers and following #27127

earl-warren commented Sep 19, 2023

fix pagination for followers and following #27127

fix pagination for followers and following #27127

Conversation

earl-warren commented Sep 19, 2023