Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase auth provider icon size on login page #27122

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Increase auth provider icon size on login page #27122

merged 4 commits into from
Sep 19, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Sep 18, 2023 •
edited
Loading

Before, 20px:
Screenshot 2023-09-19 at 00 10 05

After, 28px:
Screenshot 2023-09-19 at 00 20 40

Dropdown in account settings is unchanged at 20px:
Screenshot 2023-09-19 at 00 09 11

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 18, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2023
@silverwind silverwind added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Sep 18, 2023
@silverwind silverwind changed the title Increase icon size of OAuth providers on login page Increase auth provider icon size on login page Sep 18, 2023
@github-actions github-actions bot removed the topic/ui Change the appearance of the Gitea UI label Sep 18, 2023
@silverwind
Copy link
Member Author

silverwind commented Sep 18, 2023 •
edited
Loading

Maybe should just define height so that non-square custom logos work better.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 19, 2023
@lunny lunny added this to the 1.21.0 milestone Sep 19, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 19, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 19, 2023
@lunny lunny enabled auto-merge (squash) September 19, 2023 09:11
@silverwind silverwind removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 19, 2023
@silverwind silverwind disabled auto-merge September 19, 2023 09:17
@silverwind
Copy link
Member Author

Will do a tweak to support non-square custom icons better.

@silverwind silverwind marked this pull request as draft September 19, 2023 09:18
@silverwind
Copy link
Member Author

silverwind commented Sep 19, 2023 •
edited
Loading

Removing the width on the custom logo HTML looks somewhat okay on login button, but looks odd on dropdown. I think we better keep these square and encourage users to only use square logos.

Screenshot 2023-09-19 at 23 26 40 Screenshot 2023-09-19 at 23 29 38

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 19, 2023
@silverwind silverwind marked this pull request as ready for review September 19, 2023 21:31
@silverwind silverwind enabled auto-merge (squash) September 19, 2023 21:31
@silverwind silverwind merged commit 1b1c55f into go-gitea:main Sep 19, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 19, 2023
@silverwind silverwind deleted the loginbtns branch September 19, 2023 22:40
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 20, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
add8afe 
* giteaofficial/main:
  Improve actions docs related to `pull_request` event (go-gitea#27126)
  Remove outdated paragraphs when comparing Gitea Actions to GitHub Actions (go-gitea#27119)
  Fix: treat tab "overview" as "repositories" in user profiles without readme (go-gitea#27124)
  Fix incorrect test code for error handling (go-gitea#27139)
  Increase auth provider icon size on login page (go-gitea#27122)
  fix pagination for followers and following (go-gitea#27127)
  services/wiki: Close() after error handling (go-gitea#27129)
  Use fetch helpers instead of fetch (go-gitea#27026)
  Change green buttons to primary color (go-gitea#27099)
  Fix wrong xorm get usage on migration (go-gitea#27111)
  Fix the incorrect route path in the user edit page. (go-gitea#27007)
  Refactor lfs requests (go-gitea#26783)
  Display archived labels specially when listing labels (go-gitea#26820)
  Remove a `gt-float-right` and some unnecessary helpers (go-gitea#27110)
  [skip ci] Updated licenses and gitignores
  Fix token endpoints ignore specified account (go-gitea#27080)
  Make SSPI auth mockable (go-gitea#27036)
silverwind added a commit to silverwind/gitea that referenced this pull request Sep 21, 2023
@silverwind
Merge remote-tracking branch 'origin/main' into vitest-global
d8ee8ac 
* origin/main:
  Fix dropdown icon position (go-gitea#27175)
  Fix repo sub menu (go-gitea#27169)
  Fix review request number and add more tests (go-gitea#27104)
  Fix the variable regexp pattern on web page (go-gitea#27161)
  Fix organization field being null in POST /orgs/{orgid}/teams (go-gitea#27150)
  Add index to `issue_user.issue_id` (go-gitea#27154)
  [skip ci] Updated translations via Crowdin
  Start development on Gitea 1.22 (go-gitea#27155)
  Fix successful return value for `SyncAndGetUserSpecificDiff` (go-gitea#27152)
  Improve actions docs related to `pull_request` event (go-gitea#27126)
  Remove outdated paragraphs when comparing Gitea Actions to GitHub Actions (go-gitea#27119)
  Fix: treat tab "overview" as "repositories" in user profiles without readme (go-gitea#27124)
  Fix incorrect test code for error handling (go-gitea#27139)
  Increase auth provider icon size on login page (go-gitea#27122)
  fix pagination for followers and following (go-gitea#27127)
  services/wiki: Close() after error handling (go-gitea#27129)
  Use fetch helpers instead of fetch (go-gitea#27026)
  Change green buttons to primary color (go-gitea#27099)
  Fix wrong xorm get usage on migration (go-gitea#27111)
This was referenced Sep 26, 2023
Closed
Merged
lunny pushed a commit that referenced this pull request Sep 26, 2023
@wxiaoguang
Add missing IconHTML size (#27269)
939d410 
Fix #27223

Regression of #27122
@GiteaBot GiteaBot mentioned this pull request Sep 26, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 26, 2023
@wxiaoguang @GiteaBot
Add missing IconHTML size (go-gitea#27269)
2d02882 
Fix go-gitea#27223

Regression of go-gitea#27122
wxiaoguang added a commit that referenced this pull request Sep 26, 2023
@GiteaBot @wxiaoguang
Add missing IconHTML size (#27269) (#27283)
f0045f4 
Backport #27269 by @wxiaoguang

Fix #27223

Regression of #27122

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lunny @delvh @GiteaBot