Skip to content

Fix GetAffectedFiles failed when encountering a null old commit #26881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
+4 −0
Closed

Fix GetAffectedFiles failed when encountering a null old commit #26881

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ba00a8
fix GetAffectedFiles failed when encountering null old commit
lng2020 Sep 3, 2023
72e7cc2
Update modules/git/diff.go
lng2020 Sep 3, 2023
d95302c
fix
lng2020 Sep 3, 2023
d73a4e1
Merge remote-tracking branch 'origin/fix/GetAffectedFiles' into fix/G…
lng2020 Sep 3, 2023
3b3c115
Merge branch 'main' into fix/GetAffectedFiles
lng2020 Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/git/diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,10 @@ func CutDiffAroundLine(originalDiff io.Reader, line int64, old bool, numbersOfLi

// GetAffectedFiles returns the affected files between two commits
func GetAffectedFiles(repo *Repository, oldCommitID, newCommitID string, env []string) ([]string, error) {
// If the old commit is the null commit, then we need to use the empty tree
if oldCommitID == EmptySHA {
oldCommitID = EmptyTreeSHA
}
stdoutReader, stdoutWriter, err := os.Pipe()
if err != nil {
log.Error("Unable to create os.Pipe for %s", repo.Path)
Expand Down