Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace spaces with - in a newly created repo name and display how it will look like #26757

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+41 −4
Open

Replace spaces with - in a newly created repo name and display how it will look like #26757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d56799
implement spaces replacing
redve-dev Aug 27, 2023
e45988f
fix formatting
redve-dev Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions options/locale/locale_en-US.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,7 @@ delete_preexisting_content = Delete files in %s
delete_preexisting_success = Deleted unadopted files in %s
blame_prior = View blame prior to this change
author_search_tooltip = Shows a maximum of 30 users
repo_renamed_as = This is my template

transfer.accept = Accept Transfer
transfer.accept_desc = Transfer to "%s"
Expand Down
44 changes: 40 additions & 4 deletions templates/repo/create.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,15 @@
<div class="ui selection owner dropdown">
<input type="hidden" id="uid" name="uid" value="{{.ContextUser.ID}}" required>
<span class="text truncated-item-container" title="{{.ContextUser.Name}}">
{{ctx.AvatarUtils.Avatar .ContextUser 28 "mini"}}
<span class="truncated-item-name">{{.ContextUser.ShortName 40}}</span>
</span>
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
<div class="menu">
<div class="item truncated-item-container" data-value="{{.SignedUser.ID}}" title="{{.SignedUser.Name}}">
{{ctx.AvatarUtils.Avatar .SignedUser 28 "mini"}}
<span class="truncated-item-name">{{.SignedUser.ShortName 40}}</span>
</div>
{{range .Orgs}}
<div class="item truncated-item-container" data-value="{{.ID}}" title="{{.Name}}">
{{ctx.AvatarUtils.Avatar . 28 "mini"}}
<span class="truncated-item-name">{{.ShortName 40}}</span>
</div>
{{end}}
Expand All @@ -41,11 +38,43 @@
<span class="help">{{.locale.Tr "repo.owner_helper"}}</span>
</div>

<style>
#info_bubble {
/* DO NOT TOUCH THOSE 2 LINES */
display: none;
width: 50%;

/* and now you can customize it */
padding: 0.5em;
font-size: 0.8em;
color: #fff;
font-weight: bold;
margin-top: -3em;
}
</style>
<div class="inline field" style="margin-bottom:0; gap: 0">
<label></label>
<div id="info_bubble"></div>
</div>
<div class="inline required field {{if .Err_RepoName}}error{{end}}">
<label for="repo_name">{{.locale.Tr "repo.repo_name"}}</label>
<input id="repo_name" name="repo_name" value="{{.repo_name}}" autofocus required maxlength="100">
<span class="help">{{.locale.Tr "repo.repo_name_helper"}}</span>
</div>
<script>
const char_in_repo_name = '-'
document.getElementById("repo_name").addEventListener("input", function(event) {
var repo_name = this.value;
var bubble = document.getElementById("info_bubble");
if (repo_name.includes(' ')) {
repo_name = repo_name.replace(/ /g, char_in_repo_name);
bubble.style.display = "inline-block";
bubble.innerHTML = {{.locale.Tr "repo.repo_renamed_as"}}+`: "${repo_name}"`
} else {
bubble.style.display = "none";
}
});
</script>
<div class="inline field">
<label>{{.locale.Tr "repo.visibility"}}</label>
<div class="ui checkbox">
Expand Down Expand Up @@ -220,9 +249,16 @@
<br>
<div class="inline field">
<label></label>
<button class="ui green button{{if not .CanCreateRepo}} disabled{{end}}">
<button id="submit_button" class="ui green button{{if not .CanCreateRepo}} disabled{{end}}">
{{.locale.Tr "repo.create_repo"}}
</button>
<script>
var input = document.getElementById("repo_name");
document.getElementById("submit_button").addEventListener("click", function() {
// remove last space and replace all spaces with char_in_repo_name
input.value = input.value.replace(/\s/g, char_in_repo_name);
});
</script>
</div>
</div>
</form>
Expand Down