Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo of RunerOwnerID #26508

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Fix typo of RunerOwnerID #26508

merged 3 commits into from
Aug 15, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Aug 15, 2023

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 15, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2023
@yp05327 yp05327 added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Aug 15, 2023 •
edited
Loading

emmm, add skip change log label too quickly....
Added the labels back but got this strange log:
image
Will this break the bot?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 15, 2023
@lunny lunny added backport/v1.20 This PR should be backported to Gitea 1.20 type/miscellaneous labels Aug 15, 2023
@silverwind
Copy link
Member

Will this break the bot?

Can't really break the bot, it counts approvals only, does not read existing labels.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 15, 2023
@silverwind silverwind enabled auto-merge (squash) August 15, 2023 22:44
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 15, 2023
@silverwind silverwind merged commit bc930f3 into go-gitea:main Aug 15, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Aug 15, 2023
@GiteaBot GiteaBot mentioned this pull request Aug 15, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Aug 15, 2023
@yp05327 @GiteaBot
Fix typo of RunerOwnerID (go-gitea#26508)
aeb2a6b
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Aug 15, 2023
@yp05327 yp05327 deleted the fix-typo-of-RunnerOwner branch August 15, 2023 23:54
lunny pushed a commit that referenced this pull request Aug 16, 2023
@GiteaBot @yp05327
Fix typo of RunerOwnerID (#26508) (#26528)
0ac8b77 
Backport #26508 by @yp05327

Co-authored-by: yp05327 <576951401@qq.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 17, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
94e40c6 
* upstream/main:
  Sync repo's IsEmpty status correctly (go-gitea#26517)
  [skip ci] Updated translations via Crowdin
  Remove fomantic transition module (go-gitea#26469)
  Explain SearchOptions and fix ToSearchOptions (go-gitea#26542)
  Update go dependencies (go-gitea#26534)
  Differentiate better between user settings and admin settings (go-gitea#26538)
  Add missing triggers to update issue indexer (go-gitea#26539)
  Improve deadline icon location in milestone list page (go-gitea#26532)
  Use unique class for breadcrumb divider (go-gitea#26524)
  Fix typo of RunerOwnerID (go-gitea#26508)
  Improve clickable area in repo action view page (go-gitea#26115)
  Fix dark theme highlight for "NameNamespace" (go-gitea#26519)
  Remove duplicate CSS import for chroma/base.css (go-gitea#26523)
  Fix project filter bugs (go-gitea#26490)
  Fix display problems of members and teams unit (go-gitea#26363)
  Use `hidden` over `clip` for text truncation (go-gitea#26520)
  Add API route to list org secrets (go-gitea#26485)
  Set "type=button" for editor's toolbar buttons (go-gitea#26510)
  Apply to become a maintainer (go-gitea#26514)
  Detect ogg mime-type as audio or video (go-gitea#26494)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yp05327 @silverwind @lunny @GiteaBot