Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update djlint, enable H026 and T027 #25980

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Update djlint, enable H026 and T027 #25980

merged 1 commit into from
Jul 19, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jul 19, 2023 •
edited
Loading

New rules enabled as the bugs I reported were fixed:

  • H026 | Empty id and class tags can be removed.
  • T027 | Unclosed string found in template syntax.

Refs:

djlint/djLint#711
djlint/djLint#712

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 19, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2023
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 19, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 19, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 19, 2023
@silverwind silverwind merged commit 06df92b into go-gitea:main Jul 19, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jul 19, 2023
@silverwind silverwind deleted the djlintup branch July 19, 2023 08:35
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 20, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
84f3626 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix commit status color on dashboard repolist (go-gitea#25993)
  Improve profile readme rendering (go-gitea#25988)
  avoid hard-coding height in language dropdown menu (go-gitea#25986)
  parseScope with owner/repo always sets owner to zero (go-gitea#25987)
  Bump github.com/golang-jwt/jwt to v5 (go-gitea#25975)
  Update path related documents (go-gitea#25417)
  Update djlint, enable H026 and T027 (go-gitea#25980)
  [skip ci] Updated translations via Crowdin
  Show the mismatched ROOT_URL warning on the sign-in page if OAuth2 is enabled (go-gitea#25947)
  Refactor "Content" for file uploading (go-gitea#25851)
  Fix SSPI auth panic (go-gitea#25955)
  Make pending commit status yellow again (go-gitea#25935)
  Move public asset files to the proper directory (go-gitea#25907)
  Disallow dangerous url schemes (go-gitea#25960)
  Avoid creating directories when loading config (go-gitea#25944)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @wxiaoguang @delvh @GiteaBot