Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make indexer code more reusable #2590

Merged
merged 3 commits into from
Sep 25, 2017
Merged

Make indexer code more reusable #2590

merged 3 commits into from
Sep 25, 2017

Conversation

ethantkoenig
Copy link
Member

Changes to indexer code in support of code search (see #2582).

cc @lunny

@codecov-io
Copy link

codecov-io commented Sep 23, 2017 •
edited
Loading

Codecov Report

Merging #2590 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2590      +/-   ##
==========================================
- Coverage   27.33%   27.31%   -0.02%     
==========================================
  Files          86       86              
  Lines       17137    17146       +9     
==========================================
  Hits         4684     4684              
- Misses      11775    11784       +9     
  Partials      678      678
Impacted Files Coverage Δ
models/issue_indexer.go 8.45% <0%> (-1.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0d85c...33e9b24. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 23, 2017
@ethantkoenig ethantkoenig mentioned this pull request Sep 23, 2017
Merged
@lafriks
Copy link
Member

lafriks commented Sep 23, 2017

LGTM

@ethantkoenig
Copy link
Member Author

Make L-G-T-M work

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 24, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Sep 24, 2017
@lunny lunny added this to the 1.3.0 milestone Sep 24, 2017
@daviian
Copy link
Member

daviian commented Sep 24, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 24, 2017
@lafriks
Copy link
Member

lafriks commented Sep 24, 2017

Make LG-TM work again

@lafriks lafriks merged commit fa28de8 into go-gitea:master Sep 25, 2017
@ethantkoenig ethantkoenig deleted the update/indexer branch November 10, 2017 03:58
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ethantkoenig @codecov-io @lafriks @daviian @lunny @tboerger