Skip to content

Actions list enhancements #25601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silverwind merged 16 commits into from
Jul 4, 2023
Merged

Actions list enhancements #25601

silverwind merged 16 commits into from
Jul 4, 2023

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Jun 29, 2023 •
edited
Loading

Fixes: #25671

Various small enhancements to the actions list. Before and after:

Screenshot 2023-06-30 at 00 11 40 Screenshot 2023-06-30 at 00 09 51

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 29, 2023
@silverwind silverwind added type/enhancement An improvement of existing functionality backport/v1.20 labels Jun 29, 2023
@silverwind
Copy link
Member Author

silverwind commented Jun 29, 2023 •
edited
Loading

Can backport if it merges cleanly. Not doing manual myself.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 30, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 30, 2023
@lunny lunny added this to the 1.21.0 milestone Jun 30, 2023
@silverwind silverwind enabled auto-merge (squash) June 30, 2023 06:35
@silverwind silverwind disabled auto-merge June 30, 2023 06:36
@silverwind silverwind marked this pull request as draft June 30, 2023 06:36
@silverwind
Copy link
Member Author

silverwind commented Jun 30, 2023 •
edited
Loading

I'm not totally satisified with second line, will tweak it later.

@silverwind silverwind removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 30, 2023
@silverwind
Copy link
Member Author

silverwind commented Jul 3, 2023 •
edited
Loading

Happy with it now. I removed the "Commit" word and author name is now also a link:

Screenshot 2023-07-03 at 21 23 51

@silverwind silverwind marked this pull request as ready for review July 3, 2023 19:25
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 3, 2023
@silverwind silverwind enabled auto-merge (squash) July 3, 2023 20:11
wxiaoguang
wxiaoguang reviewed Jul 3, 2023
View reviewed changes
wxiaoguang
wxiaoguang reviewed Jul 3, 2023
View reviewed changes
@silverwind
Copy link
Member Author

silverwind commented Jul 3, 2023

Similar treatment done to single action view header:

  • Mute links
  • Move branch label to right
  • Tweak margins
Screenshot 2023-07-03 at 23 50 02

wxiaoguang
wxiaoguang reviewed Jul 3, 2023
View reviewed changes
wxiaoguang
wxiaoguang approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and nits, not block.

wxiaoguang
wxiaoguang reviewed Jul 3, 2023
View reviewed changes
@silverwind
Copy link
Member Author

silverwind commented Jul 3, 2023

This is how it looks now:

Screenshot 2023-07-04 at 00 29 55

@silverwind silverwind mentioned this pull request Jul 4, 2023
Closed
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 4, 2023
@silverwind silverwind merged commit 0006169 into go-gitea:main Jul 4, 2023
@GiteaBot
Copy link
Collaborator

GiteaBot commented Jul 4, 2023

I was unable to create a backport for 1.20. @silverwind, please send one manually. 🍵

go run ./contrib/backport 25601
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jul 4, 2023
@silverwind silverwind deleted the actlist branch July 4, 2023 10:04
@silverwind silverwind mentioned this pull request Jul 4, 2023
Merged
@silverwind silverwind added the backport/done All backports for this PR have been created label Jul 4, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@wolfogre wolfogre wolfogre approved these changes

@denyskon denyskon denyskon approved these changes

+1 more reviewer

@HesterG HesterG HesterG approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.21.0

Development

Successfully merging this pull request may close these issues.

Action workflows navbar UI has two empty items

7 participants

@silverwind @wxiaoguang @GiteaBot @wolfogre @HesterG @denyskon @lunny