Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Create column button while the column name is empty #25192

Merged
merged 12 commits into from
Jun 13, 2023
Merged

Disable Create column button while the column name is empty #25192

merged 12 commits into from
Jun 13, 2023

Conversation

puni9869
Copy link
Member

@puni9869 puni9869 commented Jun 10, 2023 •
edited by delvh
Loading

Jun-10-2023 18-43-04

Fixes #25116

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 10, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 10, 2023
@delvh delvh changed the title After the name of the new kanban in the projects, press Enter will not create the kanban. Disable Create column button while the column name is empty Jun 10, 2023
@delvh delvh added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jun 10, 2023
@delvh
Copy link
Member

delvh commented Jun 10, 2023

I have to say, without your GIF I wouldn't have had a single idea what this PR is fixing or what the original issue wanted…

@wxiaoguang
Copy link
Contributor

There are some nits in code.

Before reviewing, the question is how does this fix #25116 ? #25116 said "click new column button to input name", then the input field is not empty?

@puni9869
Copy link
Member Author

puni9869 commented Jun 10, 2023 •
edited
Loading

You are right I tried creating a kanban board using Enter key It is working fine.

My bad I miss interpret the issue.
We can change the title of the issue.
'Disable Create column button while the column name is empty'

This pr is addressed the issue

wxiaoguang
wxiaoguang reviewed Jun 12, 2023
View reviewed changes
web_src/js/features/repo-projects.js Outdated
boardTitle.closest('form').removeClass('dirty');
window.location.reload();
});
$('.new-board').on('keyup', (e) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use input instead.

Copy link
Member Author

@puni9869 puni9869 Jun 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to this $('<selector>').input((e) => {}).

I didn't find any api for this event in jquery docs https://api.jquery.com/category/events/
https://api.jquery.com/category/events/keyboard-events/

Please guide me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input is the modern event, you do: on('input', ...)

https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/input_event

For example, right click, paste doesn't trigger 'keyup' but it triggers 'input'.

wxiaoguang
wxiaoguang approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although there are nits, overall LGTM.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 13, 2023
@lunny lunny added this to the 1.21.0 milestone Jun 13, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 13, 2023
@lunny lunny enabled auto-merge (squash) June 13, 2023 09:33
@lunny lunny merged commit 2ad2d5a into go-gitea:main Jun 13, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 13, 2023
@puni9869 puni9869 deleted the punit/ISSUE-25116-fix-kanban-column branch June 13, 2023 12:36
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 15, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
de2c98c 
* upstream/main: (31 commits)
  Show OAuth2 errors to end users (go-gitea#25261)
  [skip ci] Updated translations via Crowdin
  Fix index generation parallelly failure (go-gitea#25235)
  Fix variable in template (go-gitea#25267)
  Add template linting via djlint (go-gitea#25212)
  Fix edit OAuth application width (go-gitea#25262)
  Use flex to align SVG and text (go-gitea#25163)
  GitHub Actions enhancements for frontend (go-gitea#25150)
  Add missing `v` in migrations.go (go-gitea#25252)
  Change form actions to fetch for submit review box (go-gitea#25219)
  Fix panic when migrating a repo from GitHub with issues (go-gitea#25246)
  Fix description of drop custom_labels migration (go-gitea#25243)
  Fix all possible setting error related storages and added some tests (go-gitea#23911)
  [skip ci] Updated translations via Crowdin
  Revert overflow: overlay (revert go-gitea#21850) (go-gitea#25231)
  Support changing labels of Actions runner without re-registration (go-gitea#24806)
  Improve AJAX link and modal confirm dialog (go-gitea#25210)
  Use inline SVG for built-in OAuth providers (go-gitea#25171)
  Disable `Create column` button while the column name is empty  (go-gitea#25192)
  Fix profile render when the README.md size is larger than 1024 bytes (go-gitea#25131)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

After the name of the new kanban in the projects, press Enter will not create the kanban
5 participants
@puni9869 @delvh @wxiaoguang @lunny @GiteaBot