-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change --font-weight-bold
to --font-weight-semibold
and 600 value, introduce new font weight variables
#24827
Conversation
Comment could be left there (and be improved), then some Linux users without correct font environment could know the details, and it could save contributors time if similar issue comes. And I think it needs to be backported? |
Hmm, I don't feel like commenting this, 600 is a pretty standard weight. Backport will be done, yes. |
We have spent a lot of time on this problem. Maybe in the future some other users would also report similar problems, then some new maintainers without this knowledge would waste time on this problem again. |
Well, a new issue ... Bold text no longer displayed as bold #24835 |
What should we write into that comment? 601 was a "odd" value that caused issues and in some cases renders as 700 which we do not want from a design perspective. Multiples of 100 seem to generally work best. For clarity, I would like to rename the variable. As per MDN: 400 | Normal So we could make: --font-weight-normal That will satisfy all future use cases. I would not comment any of these, they are standard values. |
I think the "situation" could be documented:
The key information:
It would save a lot of time for future developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wouldn't like to write comment or remove unused variable, I could do it in next PR, I won't block for nits.
Will do a bit more refactor to use variables everywhere. |
Refactor done, now all CSS uses these variables, enforced by a linter rule, and there are tailwind-matching helper classes as well for them. |
--font-weight-bold
to 600--font-weight-bold
to 600 and introduce new font weight variables
--font-weight-bold
to 600 and introduce new font weight variables--font-weight-bold
to --font-weight-semibold
and introduce new font weight variables
--font-weight-bold
to --font-weight-semibold
and introduce new font weight variables--font-weight-bold
to --font-weight-semibold
and 600 value, introduce new font weight variables
* main: Rewrite logger system (go-gitea#24726) Support Copy Link for video attachments (go-gitea#24833) Fix video width overflow in markdown, and other changes to match img (go-gitea#24834) Improve accessibility when (re-)viewing files (go-gitea#24817)
* giteaofficial/main: (27 commits) Fix regression: access log template, gitea manager cli command (go-gitea#24838) Merge message template support for rebase without merge commit (go-gitea#22669) [skip ci] Updated licenses and gitignores Support wildcard in email domain allow/block list (go-gitea#24831) Change `--font-weight-bold` to `--font-weight-semibold` and 600 value, introduce new font weight variables (go-gitea#24827) Rewrite logger system (go-gitea#24726) Support Copy Link for video attachments (go-gitea#24833) Fix video width overflow in markdown, and other changes to match img (go-gitea#24834) Improve accessibility when (re-)viewing files (go-gitea#24817) Refactor rename user and rename organization (go-gitea#24052) Use `CommentList` instead of `[]*Comment` (go-gitea#24828) Fix topics deleted via API not being deleted in org page (go-gitea#24825) Return `404` in the API if the requested webhooks were not found (go-gitea#24823) Decouple the different contexts from each other (go-gitea#24786) [skip ci] Updated translations via Crowdin Add RTL rendering support to Markdown (go-gitea#24816) [skip ci] Updated translations via Crowdin Update JS dependencies (go-gitea#24815) Fix duplicate tooltip hiding (go-gitea#24814) Mute repo names in dashboard repo list (go-gitea#24811) ...
…00 value, introduce new font weight variables (go-gitea#24827)" This reverts commit 19993d8.
* main: Improvements for action detail page (go-gitea#24718) Add CRAN package registry (go-gitea#22331) Fix regression: access log template, gitea manager cli command (go-gitea#24838) Merge message template support for rebase without merge commit (go-gitea#22669) [skip ci] Updated licenses and gitignores Support wildcard in email domain allow/block list (go-gitea#24831) Change `--font-weight-bold` to `--font-weight-semibold` and 600 value, introduce new font weight variables (go-gitea#24827) Rewrite logger system (go-gitea#24726) Support Copy Link for video attachments (go-gitea#24833)
* Fix broken doc link: https://github.com/go-gitea/gitea/actions/runs/5041309438/jobs/9040887385 * Improve comments about how font weight works: #24827 (review) --------- Co-authored-by: silverwind <me@silverwind.io>
Backport of go-gitea#24827 to 1.19, just the font weight reduction. (cherry picked from commit e81d38b)
This is correct. I am the submitter of #24305. On the still affected device (MX Linux), i just now downloaded a Linux version of Segoe-UI from here, installed it and restarted my browser, and this device is now displaying the bold/semibold text correctly. |
There was some recent discussion about this in Discord
ui-design
channel and the conclusion was that #24305 should have fixed their OS font installation to have semibold weights.I have now tested this 601 weight on a Windows 10 machine on Firefox myself, and I immediately noticed that bold was excessivly bold and rendering as 700 because browsers are biased towards bolder fonts. So revert this back to the previous value.