-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have "make" create the executable in root dir #247
Conversation
No, you only want to update the build task, not the release stuff. |
On Thu, Nov 24, 2016 at 04:02:58PM -0800, Thomas Boerger wrote:
No, you only want to update the build task, not the release stuff.
If I read he release stuff correctly it creates binaries under bin/
and then copies them over dist/, any reason no to *move* them rather
than copy them, or even better create them in dist/ directly ?
|
In any case I've pushed a change keeping "release" build under bin/
|
Now release is entirely broken... |
Ok, it looks like I'll have to patiently wait for karalabe/xgo-latest
docker pull and actually try to run those targets.
Please stand by... (or feel free to send a new PR with the correct
fix replacing this!)
|
After downloading the docker image required for "make release" I don't see what problem |
release-copy and latest-copy can't work anymore |
Should be fixed with ee7b6e2 |
Ok, do everything in the root dir but make sure that all make tasks stay working and drop bin from gitignore. The release part should be moved entirely to the dist folder |
You asked me to not touch the release part, it's untouched now, no ? Don't have time to go back and forth, feel free to file a new PR the way you want if not planning to merge this. |
@strk if you give me permission to, I can push the requested fix to your branch 🙂 |
@bkcsoft sounds like it would require too much GUI Web browser interaction, how about you give me an url to your published branch and I merge it ? :) |
LGTM |
Same as "go build". Makes it functional by default as it'd then find template/ and public/ by default w/out setting GITEA_WORK_DIR
LGTM |
* Restore accidentally-removed Google Analytics JS * Empty commit to rerun CI
Same as "go build".
Makes it functional by default as it'd then find template/ and public/
by default w/out setting GITEA_WORK_DIR