Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no edit/close/delete button in org repo project view page #24301

Merged

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Apr 24, 2023

Part of #23318.

@GiteaBot GiteaBot added this to the 1.20.0 milestone Apr 24, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2023
@delvh delvh added the type/bug label Apr 24, 2023
@delvh
Copy link
Member

delvh commented Apr 24, 2023

backport?

@silverwind silverwind added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Apr 24, 2023
@silverwind
Copy link
Member

Seems present in 1.19: https://github.com/go-gitea/gitea/blob/release/v1.19/templates/repo/projects/view.tmpl. Likely a copy-paste issue done a long time ago?

@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2023
@silverwind
Copy link
Member

Came in beab1dd.

@delvh delvh enabled auto-merge (squash) April 24, 2023 08:17
@delvh delvh merged commit 9c33cbd into go-gitea:main Apr 24, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2023
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.19. @yp05327, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 24, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 24, 2023
* giteaoffical/main:
  Improve some modal action buttons (go-gitea#24289)
  Enable forbidigo linter (go-gitea#24278)
  Fix no edit/close/delete button in org repo project view page  (go-gitea#24301)
  Replace whitespace inside template parens during make fmt (go-gitea#24293)
  Upgrade act  (go-gitea#24298)
@yp05327 yp05327 deleted the fix-no-delete-menu-in-repo-project-view-page branch April 25, 2023 06:02
@yp05327
Copy link
Contributor Author

yp05327 commented Apr 26, 2023

@GiteaBot
Done.

ps: Why you can't backport, there's no conflicts. 😕

@silverwind
Copy link
Member

cc: @yardenshoham how are backports done? Just a cherry-pick?

@silverwind
Copy link
Member

@yp05327 maybe next time you see this issue, try to replicate the steps the bot does so we can figure out where it goes wrong.

@yardenshoham yardenshoham added the backport/done All backports for this PR have been created label Apr 26, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Apr 26, 2023

@silverwind
I see. I will try next time. :)

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants