Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go tool dependencies, restructure lint targets #24239

Merged
merged 20 commits into from
Apr 22, 2023
Merged

Update go tool dependencies, restructure lint targets #24239

merged 20 commits into from
Apr 22, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 20, 2023 •
edited
Loading

  • Update all tool dependencies to latest tag
  • Remove unused errcheck, it is part of golangci-lint
  • Include main.go in air
  • Enable wastedassign again now that it's generics-compatible
  • Restructured lint targets to new lint-* namespace

@silverwind silverwind added this to the 1.20.0 milestone Apr 20, 2023
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 20, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 20, 2023
@silverwind

This comment was marked as resolved.

Sign in to view
@silverwind silverwind marked this pull request as draft April 20, 2023 23:51
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2023
@silverwind
Copy link
Member Author

Ready now.

@silverwind silverwind marked this pull request as ready for review April 22, 2023 07:47
delvh
delvh reviewed Apr 22, 2023
View reviewed changes
services/gitdiff/gitdiff_test.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
modules/timeutil/since.go Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2023
@silverwind silverwind changed the title Update go tool dependencies Update go tool dependencies, restructure lint targets Apr 22, 2023
@silverwind
Copy link
Member Author

silverwind commented Apr 22, 2023 •
edited
Loading

New lint targets:

 - lint                             lint everything
 - lint-frontend                    lint frontend files
 - lint-backend                     lint backend files
 - lint-go                          lint go files
 - lint-go-fix                      lint go files and fix issues
 - lint-go-vet                      lint go files with vet
 - lint-js                          lint js files
 - lint-js-fix                      lint js files and fix issues
 - lint-css                         lint css files
 - lint-css-fix                     lint css files and fix issues
 - lint-md                          lint markdown files
 - lint-swagger                     lint swagger files

@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2023
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 22, 2023
delvh
delvh reviewed Apr 22, 2023
View reviewed changes
Makefile Show resolved Hide resolved
delvh
delvh approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wasn't what I meant with

that lints everything and fixes what it can

But that is fine too.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 22, 2023
@silverwind
Copy link
Member Author

Hmm could do as well. I though anyone running that target would be more interesting in the fixing aspect than the linting aspect, but I see your idea is better.

@silverwind
Copy link
Member Author

silverwind commented Apr 22, 2023 •
edited
Loading

@delvh added, I also added intermediate targets so now we have this extensive list:

 - lint                             lint everything
 - lint-fix                         lint everything and fix issues
 - lint-frontend                    lint frontend files
 - lint-frontend-fix                lint frontend files and fix issues
 - lint-backend                     lint backend files
 - lint-backend-fix                 lint backend files and fix issues
 - lint-go                          lint go files
 - lint-go-fix                      lint go files and fix issues
 - lint-go-vet                      lint go files with vet
 - lint-js                          lint js files
 - lint-js-fix                      lint js files and fix issues
 - lint-css                         lint css files
 - lint-css-fix                     lint css files and fix issues
 - lint-md                          lint markdown files
 - lint-swagger                     lint swagger files

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 22, 2023
@silverwind silverwind enabled auto-merge (squash) April 22, 2023 15:46
@silverwind silverwind merged commit 8dc6eab into go-gitea:main Apr 22, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 22, 2023
@silverwind silverwind deleted the tooldeps-3 branch April 22, 2023 19:46
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser left review comments

@wxiaoguang wxiaoguang wxiaoguang left review comments

@delvh delvh delvh approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @wxiaoguang @6543 @jolheiser @delvh @GiteaBot