Fix profile page email display, respect settings (#23747) #23756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always respect the `setting.UI.ShowUserEmail` and `KeepEmailPrivate` setting. * It doesn't make sense to show user's own E-mail to themself. * Always hide the E-mail if KeepEmailPrivate=true, then the user could know how their profile page looks like for others. * Revert the `setting.UI.ShowUserEmail` change from go-gitea#4981 . This setting is used to control the E-mail display, not only for the user list page. ps: the incorrect `<div .../>` tag on the profile page has been fixed by go-gitea#23748 together, so this PR becomes simpler.
jolheiser
approved these changes
Mar 27, 2023
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Mar 27, 2023
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23747 by @wxiaoguang
Always respect the
setting.UI.ShowUserEmailandKeepEmailPrivatesetting.setting.UI.ShowUserEmailchange from Show email if the authenticated user owns the profile page being requested for #4981 . This setting is used to control the E-mail display, not only for the user list page.ps: the incorrect
<div .../>tag on the profile page has been fixed by #23748 together, so this PR becomes simpler.