Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove row clicking from notification table (#22695) #23706

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Mar 25, 2023

Backport #22695 by @jolheiser

Resolves #22692

Resolves go-gitea#22692

I don't think there's a need for this entire row to be clickable (and
even different links depending on which segment you click)
The links still point to the same spot, so no information is lost here.

---------

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added the topic/ui Change the appearance of the Gitea UI label Mar 25, 2023
@GiteaBot GiteaBot added this to the 1.19.1 milestone Mar 25, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 25, 2023
@lafriks lafriks merged commit 305cac2 into go-gitea:release/v1.19 Mar 25, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@techknowlogick techknowlogick deleted the backport-22695-v1.19 branch September 9, 2023 05:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants