Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use CleanPath instead of path.Clean" #23493

Closed
wants to merge 1 commit into from
Closed

Revert "Use CleanPath instead of path.Clean" #23493

wants to merge 1 commit into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 15, 2023

Since there are many problems with #23371, revert and rewrite is a better idea.

Reverts #23371

@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 15, 2023
@lunny lunny mentioned this pull request Mar 15, 2023
Closed
@wxiaoguang wxiaoguang mentioned this pull request Mar 15, 2023
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 15, 2023
@wxiaoguang
Copy link
Contributor

After discussed with lunny, this PR has conflicts with latest commits, I proposed a new PR

jolheiser pushed a commit that referenced this pull request Mar 21, 2023
@wxiaoguang
Introduce path Clean/Join helper functions (#23495)
ce9dee5 
Since #23493 has conflicts with latest commits, this PR is my proposal
for fixing #23371

Details are in the comments

And refactor the `modules/options` module, to make it always use
"filepath" to access local files.

Benefits:

* No need to do `util.CleanPath(strings.ReplaceAll(p, "\\", "/"))),
"/")` any more (not only one before)
* The function behaviors are clearly defined
@wxiaoguang
Copy link
Contributor

Update: #23495 has been merged

@lunny lunny closed this Mar 22, 2023
@lunny lunny deleted the revert-23371-lunny/clean_path branch March 22, 2023 02:52
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wxiaoguang @zeripath @GiteaBot