Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CleanPath instead of path.Clean (#23371) #23442

Closed
wants to merge 1 commit into from
Closed

Use CleanPath instead of path.Clean (#23371) #23442

wants to merge 1 commit into from

Conversation

wolfogre
Copy link
Member

Backport #23371.

As title.

@wolfogre wolfogre added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 13, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 13, 2023
@lunny lunny added this to the 1.19.0 milestone Mar 13, 2023
zeripath
zeripath suggested changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many issues with this PR - it will result in paths that previously could not have an initial "/" to now possibly have a preceding "/"

This is very likely to introduce several bugs.

@wolfogre wolfogre closed this Mar 16, 2023
@lunny lunny removed this from the 1.19.0 milestone Mar 16, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath requested changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wolfogre @lunny @zeripath @GiteaBot