Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoped labels: don't require holding alt key to remove #23303

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Scoped labels: don't require holding alt key to remove #23303

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3db747e
Scoped labels: don't require holding alt key to remove
brechtvl Mar 4, 2023
c6d0b16
Merge branch 'main' into scoped-label-toggle-no-alt
lafriks Mar 5, 2023
c4ad236
Merge branch 'main' into scoped-label-toggle-no-alt
lunny Mar 6, 2023
0ffc1ca
Merge branch 'main' into scoped-label-toggle-no-alt
lunny Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions web_src/js/features/repo-legacy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,19 +145,14 @@ export function initRepoCommentForm() {

const clickedItem = $(this);
const scope = $(this).attr('data-scope');
const canRemoveScope = e.altKey;

$(this).parent().find('.item').each(function () {
if (scope) {
// Enable only clicked item for scoped labels
if ($(this).attr('data-scope') !== scope) {
return true;
}
if ($(this).is(clickedItem)) {
if (!canRemoveScope && $(this).hasClass('checked')) {
return true;
}
} else if (!$(this).hasClass('checked')) {
if (!$(this).is(clickedItem) && !$(this).hasClass('checked')) {
return true;
}
} else if (!$(this).is(clickedItem)) {
Expand Down