Fix code view (diff) broken layout #23096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
code-view-layout
branch
from
9cfec6d
to
b90c4e2
Compare
wxiaoguang
changed the title
wxiaoguang
changed the title
|
Make sure to test the code expansion via these buttons:
This stuff is sensitive to column number. |
GiteaBot
added
the
lgtm/need 2
Yes, I have tested, that's in |
|
Thanks @wxiaoguang. I have done some testing and it looks like this fixes the problem without any noticeable regressions. So, functionally it works as expected. I don't feel experienced enough with html / css to approve the PR myself from the technical point of view though. |
|
Since it works, I hope I can receive a LGTM from you later. No hurry, take enough time to test till you feel it works really well. And no worry, I will fix all bugs caused by me. |
delvh
added
type/bug
topic/ui
lafriks
approved these changes
Apr 2, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 3, 2023
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #23096 +/- ##
===========================================
- Coverage 47.14% 0 -47.15%
===========================================
Files 1149 0 -1149
Lines 151446 0 -151446
===========================================
- Hits 71397 0 -71397
+ Misses 71611 0 -71611
+ Partials 8438 0 -8438 see 1149 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 4, 2023
Close go-gitea#22911 I think it's ready for review now, feel free to test it, welcome to help to improve. ### Before  ### After 
6543
pushed a commit
that referenced
this pull request
Apr 4, 2023
Backport #23096 by @wxiaoguang Close #22911 I think it's ready for review now, feel free to test it, welcome to help to improve. ### Before  ### After  Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 5, 2023
* giteaoffical/main: Fix image border-radius (go-gitea#23886) [skip ci] Updated translations via Crowdin Scroll collapsed file into view (go-gitea#23702) docs: make the required backticks in email password more explicit (go-gitea#23923) docs: fix typo (go-gitea#23924) Update docs markdown file weight to make it clear (go-gitea#23909) Add activity feeds API (go-gitea#23494) Fix code view (diff) broken layout (go-gitea#23096) Use ghost user if package creator does not exist (go-gitea#23822) Org pages style fixes (go-gitea#23901) User/Org Feed render description as per web (go-gitea#23887)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #22911
I think it's ready for review now, feel free to test it, welcome to help to improve.
Before
After