Skip to content

Remove unnecessary and incorrect find('.menu').toggle() #22987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jolheiser merged 8 commits into from
Feb 20, 2023
Merged

Remove unnecessary and incorrect find('.menu').toggle() #22987

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2b1dba4
fix
wxiaoguang Feb 19, 2023
890377e
Merge branch 'main' into remove-menu-hide
wxiaoguang Feb 20, 2023
aee8b7e
Merge branch 'main' into remove-menu-hide
wxiaoguang Feb 20, 2023
b23fd12
Merge branch 'main' into remove-menu-hide
delvh Feb 20, 2023
6642429
Merge branch 'main' into remove-menu-hide
delvh Feb 20, 2023
6480c97
Merge branch 'main' into remove-menu-hide
delvh Feb 20, 2023
508f8df
Merge branch 'main' into remove-menu-hide
delvh Feb 20, 2023
b529823
Merge branch 'main' into remove-menu-hide
jolheiser Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions web_src/js/features/repo-issue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,8 +552,6 @@ export function initRepoIssueReferenceIssue() {
// Reference issue
$(document).on('click', '.reference-issue', function (event) {
const $this = $(this);
$this.closest('.dropdown').find('.menu').toggle('visible'); // eslint-disable-line

const content = $(`#${$this.data('target')}`).text();
const poster = $this.data('poster-username');
const reference = $this.data('reference');
Expand Down
2 changes: 0 additions & 2 deletions web_src/js/features/repo-legacy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ export function initRepoCommentForm() {
async function onEditContent(event) {
event.preventDefault();

$(this).closest('.dropdown').find('.menu').toggle('visible'); // eslint-disable-line
const $segment = $(this).closest('.header').next();
const $editContentZone = $segment.find('.edit-content-zone');
const $renderContent = $segment.find('.render-content');
Expand Down Expand Up @@ -584,7 +583,6 @@ function initRepoIssueCommentEdit() {

// Quote reply
$(document).on('click', '.quote-reply', function (event) {
$(this).closest('.dropdown').find('.menu').toggle('visible'); // eslint-disable-line
const target = $(this).data('target');
const quote = $(`#${target}`).text().replace(/\n/g, '\n> ');
const content = `> ${quote}\n\n`;
Expand Down